Skip to content

navigation-testing - redirect to published artifacts - #3264

Merged
Igor Demin (igordmn) merged 2 commits into
jb-mainfrom
igor.demin/use-navigation-testing-redirection
Jul 27, 2026
Merged

navigation-testing - redirect to published artifacts#3264
Igor Demin (igordmn) merged 2 commits into
jb-mainfrom
igor.demin/use-navigation-testing-redirection

Conversation

@igordmn

@igordmn Igor Demin (igordmn) commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Part of https://youtrack.jetbrains.com/issue/CMP-10569/Setup-GitHub-action-in-integration-branch

Requirement for #3256

Reason:

  • navigation-testing doesn't redirect currently to anything
  • it depends on navigation-runtime, which redirects all the targets
  • there was an incompatible change between navigation-runtime and navigation-testing (remove/add methods in interface)
  • this change leaded to compilation error, because navigation-testing uses the new interface, but it depends on an interface from the old redirected navigation-runtime
  • it works in AOSP because they built both modules from sources and they don't have to preserve compatibility because it is one group

Release Notes

N/A

afterConfigure: () -> Unit,
) {
if (isJetBrainsFork(project) && JetBrainsPublication.shouldPublish(this)) return
if (isJetBrainsFork(project)) return

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fully disables the old MavenUploadHelper (we have own inside org.jetbrains). Cleanup will be in https://youtrack.jetbrains.com/issue/CMP-10570/Cleanup-buildSrc-fork-code

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not publish it. Why do we need to setup redirects here?

@igordmn Igor Demin (igordmn) Jul 24, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redirects now affects usual demos/tests too. By design I see redirects as "instead of sources use this artifact", and it fixes well the issue I described in in the description.

@igordmn
Igor Demin (igordmn) merged commit c88e05e into jb-main Jul 27, 2026
28 checks passed
@igordmn
Igor Demin (igordmn) deleted the igor.demin/use-navigation-testing-redirection branch July 27, 2026 09:57
Igor Demin (igordmn) added a commit that referenced this pull request Jul 27, 2026
Fixes
https://youtrack.jetbrains.com/issue/CMP-10569/Setup-GitHub-action-in-integration-branch

Run GitHub Actions workflows on pushes to the integration branch.

## Testing
1. go to integration branch
2. cherry pick:
  - #3263
  - #3264
  - #3256
3. update API dump
4. run GitHub actions

## Release Notes
N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants