Feat/cross channel spam automod#553
Open
Neil-Tomar wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a second spam automod —
checkCrossChannelSpaminAutoMod— that catches a pattern the existing same-channel spam check misses: a single user rapidly spreading messages across several different channels.What it does
ModerationConfig, so they're tunable per guild.How it works
CachedMessagenow stores achannelId, taken from the live message when it's cached — so the cache knows which channel each message came from. That's what lets the check count distinct channels without any extra Discord API calls; only the timeout and the deletions talk to Discord.checkCrossChannelSpamreads the author's recent messages from theMessageCachewithin the window, gathers the distinct channels, and passes the messages tohandleSpamonce the count crosses the threshold.handleSpamgains aList<CachedMessage>overload that times the user out and deletes each message by id.ModerationConfigfields:crossChannelSpamWindowSecondsandcrossChannelSpamMinChannels.Notes
channelIdisn't persisted to the database yet — it defaults to-1when read from the DB, per your suggestion. If it holds up, I can follow with a migration to store it properly.