Repository navigation
fix(internet): give IGMPv2 and IGMPv3 versioned names - #2590
Merged
Merged
Conversation
- `IGMPv2.name` and `IGMPv3.name` return 'Internet Group Management Protocol version 2' / '... version 3', overriding the family base's unversioned name; IGMPv1 keeps the base's, as RFC 1112 names it. - Document the new `name` property on the IGMPv2 and IGMPv3 pages. - Pin all three names on parsed layers, and update the IGMPv2 name pin in `test_igmp_index_length_and_name`.
JarryShaw
added
fix
Owner
Author
|
GOOD TO GO at |
Contributor
|
Coverage: 94.03% (unit tier, Python 3.15,
Per-file detail: the |
JarryShaw
removed
the
review: good-to-go
JarryShaw
added a commit
that referenced
this pull request
Nov 2, 2026
…1.6.0 (#2449) - Added: DCCP, its checksum over the IP pseudo-header, register_dccp and register_dccp_option, and the pcapkit.const.dccp registries (#2593). - Folded into unreleased entries: LinuxSLL's stop on its ARPHRD path (#2587) and ARPHRD's __proto_dest__ (#2598), SSLv2 records chained in a segment (#2585), the checksum's move to pcapkit.corekit.checksum.internet (#2586), and IGMPv2's and IGMPv3's versioned name (#2590). - Breaking: InARP moves to pcapkit.protocols.link.inarp with no re-export, joining the DRARP entry (#2596). - Changed: the conventions' new rulings (#2599), the milestone workflow's next-open-milestone lookup (#2591), the PyPy protocols shards (#2604). Fixed: a handled next-layer refusal is quiet under beholder (#2597); the IPX crawlers restore sys.path (#2601). - CHANGELOG.md regenerated; util/changelog_md.py --check passes.
1 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
fix— corrects a defectDescription of your pull request and other information
IGMPv2.nameandIGMPv3.namenow return 'Internet Group Management Protocol version 2' and '... version 3', overriding the family base's unversioned name. That matchesaliasandid(), and protocol-family-grouping.rst's "Canonical Names". IGMPv1 keeps the plain name, because RFC 1112 calls it IGMP. The IGMPv2 and IGMPv3 pages document the new property, and the IGMP tests pin all three names.A scratch merge with current
mainpasses the member-order guard and the IGMP unit module.Closes #2558