Repository navigation
chore(deps): bump dictdumper pin in conda/requirements.txt and benchmark requirements - #2450
Merged
Merged
Conversation
…ark requirements (#2447) - conda/requirements.txt and examples/benchmark/requirements-common.txt still pinned dictdumper==0.8.4.post6, below pyproject.toml's `dictdumper~=0.8.0` floor as raised by #2442/#2445's fixes. - create-release.yml's Setup Conda Distribution step installs straight from the committed conda/requirements.txt, so a release cut before the Conda Update cron regenerates it would ship 0.8.4.post6 -- the version with the double-escaping/key-escaping defects #2442 fixed. - Bump both pins to dictdumper==0.8.5, matching each file's existing exact-pin style. tests/project/test_conda_vendor_1814.py passes against the new pin; tests/project/ as a whole shows no change in behaviour versus main.
JarryShaw
added
the
chore
JarryShaw
added
review: running
Owner
Author
|
Verified directly: both pins bumped to |
JarryShaw
removed
the
review: good-to-go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
make pylint,make mypy,make isort) -- no code touched, pins onlymake testpasses, and a test case covers the change --tests/project/test_conda_vendor_1814.py::CommittedListTestsassertsconda/requirements.txtagainstpyproject.toml's floordocs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible -- not user-visible, dependency pin maintenance onlyWhat is the purpose of your pull request?
chore-- anything elseDescription of your pull request and other information
Fixes #2447.
conda/requirements.txtandexamples/benchmark/requirements-common.txtstill pinneddictdumper==0.8.4.post6, belowpyproject.toml'sdictdumper>=0.8.5floor raised by #2442/#2445's double-escaping/key-escaping fixes.create-release.yml's Setup Conda Distribution step installs straight from the committedconda/requirements.txt, so a release cut before the Conda Update cron regenerates it would ship the defective version.Both pins bumped to
dictdumper==0.8.5, matching each file's existing exact-pin (==) style.Test plan
tests/project/test_conda_vendor_1814.py::CommittedListTests-- passes against the new pin (15 passed, 8 subtests passed).tests/project/as a whole shows no behavioural change from this edit; the suite's existing failures/errors (subprocessPYTHONPATH/utilresolution, missingrequests/network access) reproduce identically on unmodifiedmainwith the same fresh venv, confirming they predate and are unrelated to this change.