Repository navigation
Conversation
…pdater pin (#1811) Under #1103's ruling, the pinned counts in process.rst, registry-protocol.rst, sentinel-convention.rst, workflows.rst and releasing.rst become count-free, along with the sentences that restated them. - Pins that only matched a number are deleted: the changelog entry count, the phase-two and audit figures, the helper tally, the workflow count, the leg counts and the release-check counts. - Pins that guarded a real fact now check it by name: the sentinel table matches the module's singletons, phase 2 has no enumeration outside the hierarchy, the helper row names each helper, the changelog sections match the packages, and the gate-only list matches unit-tests.yml's gated matrix jobs. - util/update_python_versions.py drops its count claims and the Word machinery. Its version and line-citation claims stay. tests/project: 966 passed, 1 skipped. Each new guard fails on a broken scratch copy. Closes #1811
Owner
Author
|
Verdict: GOOD TO GO at |
4 of 13 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change. Narrow runs only, listed below.Added a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseSummary
Applies the ruling on #1103 (no counted numbers in the docs) to the pages whose counts tests and the python-versions updater pinned. The prose and its pins go in one change.
Prose:
process.rst,registry-protocol.rst,sentinel-convention.rst,workflows.rstandreleasing.rstlose their pinned counts and the sentences that quoted them. Each rewrite was checked against the tree.Pins: each is deleted, or replaced by a check of the underlying fact without a number in prose:
unit-tests.yml's gated matrix jobs;experimental.yml's.Every replacement guard fails when its fact breaks.
Updater (
util/): the claims that rewrote counts are gone, and every version-range and latest-version claim stays. No workflow YAML changes.Runs:
tests/projectand the sentinel test pass, and the changed modules pass under plainunittesttoo.Unpinned counts on these pages are left for #1103's round 3.
Closes #1811