Repository navigation
Conversation
…#1807) - data/schema internet: re-export the MH messages, options, suboptions, attributes and extensions, and the HOPOPT and IPv6-Opts SMFDPDOption and QuickStartOption bases, under their MH_/HOPOPT_/IPv6_Opts_ prefixes. - schema internet: re-export ipv4.Option as IPv4_Option and ipv6_route.RoutingType as IPv6_Route_RoutingType. - data/schema misc: re-export PacketBlock and the PACK_* options as PCAPNG_*. - data application: re-export httpv2.Settings as HTTPv2_Settings. - data and schema aggregators list every new name. - ipv6_option's field callbacks stay module-only, recorded in the test. - tests: walk every data and schema package and check it re-exports its children's __all__ by identity, that the allowlist is tight, and that no star-import is shadowed. Fails on origin/main; protocol suites pass. Closes #1807
Owner
Author
|
Verdict: GOOD TO GO at |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change. Narrow runs only, listed below.Added a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseSummary
#1797 found
pcapkit.protocols.data.linkmissing the L2TP data model (fixed in #1806). The same gap was open across the data and schema packages: names a submodule lists in__all__that its package and aggregator did not re-export.data/schemaaggregators, under the prefixes the siblings use:MH_*);SMFDPDOptionandQuickStartOption(HOPOPT_*,IPv6_Opts_*);ipv4.Optionandipv6_route.RoutingTypeon the schema side;PacketBlockand thePACK_*options (PCAPNG_*);Settings(HTTPv2_Settings).schema.internet.ipv6_optionfield callbacks. No package re-exports field callbacks, the same names exist in sibling modules, andipv6_option.rstdocuments them on their own page. They are recorded in the new test's allowlist.tests/protocols/test_package_reexports_1807_unit.pywalks every data and schema package and checks re-export by identity, a tight allowlist, and no shadowed star-imports. It fails onmain.pcapkit's own top-level names are unchanged. Additions only.Closes #1807