Repository navigation
Conversation
- Drop the "blocked on dictdumper" skip from PcapngUnescapedKeyTests.test_json_report_of_a_decryption_secrets_block_parses. #1158 made pcapkit.dumpkit escape JSON mapping keys itself, so the test.pcapng report parses although dictdumper 0.8.4.post6 still writes keys raw (JarryShaw/DictDumper#121). - Give the class the HAS_RUNTIME guard its siblings carry; _helpers.py to match. - Rewrite the class and test docstrings to say what the test now guards, citing symbols instead of the stale pcapng.py:2244 / common.py:351 lines, and fix the PCAPNG_SECTIONS comment that called the report unreadable. Bite: with escape_key's JSON branch returning the key unchanged, the test fails with "JSONDecodeError: Expecting ':' delimiter"; restored, it passes. The file, tests/project and tests/test_tier_guard.py pass. Closes #1795
Owner
Author
|
Verdict: GOOD TO GO at |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change. Narrow runs only, listed below.Added a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseSummary
tests/integration/test_pcapng_end_to_end.pyskippedPcapngUnescapedKeyTests.test_json_report_of_a_decryption_secrets_block_parsesas "blocked on dictdumper". #1158 (for #1152) made pcapkit escape JSON mapping keys itself, so the block was no longer real.HAS_RUNTIMEguard added, matching the sibling classes, so a checkout without the runtime dependencies skips rather than fails.tests/integration/_helpers.pynow says every subclass carries the guard.escape_key's JSON branch turned into a no-op, the test fails withJSONDecodeError. WithHAS_RUNTIMEfalse, it skips.tests/projectandtests/test_tier_guard.pypass.Closes #1795