Repository navigation
docs(tests): second whole-repo pass over tests (#1103) - #1805
Merged
Merged
Conversation
Prose only: with every string expression statement blanked, each changed module's AST is identical to origin/main's. - RFC 959: the case-folding rule sits in Section 5.3, not 4.1, in the #896 and #903 modules (RFC text, line 2559). - Counts: the release-gate mutation table's #966 block is six rows, not five; the comment now sums to the table's 21. - pack(): the GH-452 HTTP docstring describes pack() as it is after #1791, building on _packing_target(); the MPTCP stale-flags case says make, which it calls. - Line references re-measured against origin/main: 23 pointers in 14 files, into protocol.py, frame.py, field.py, byteorder.py, the five UnsupportedCall sites, tcp.py, ipv6.py, extension_header.py, the pcapng schema, apptype.py and vendor/__main__.py. Refs #1103
Owner
Author
|
Verdict: GOOD TO GO at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change. Narrow runs only, listed below.Added a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseSummary
#1103 second whole-repo pass, tests slice.
Prose only: with every string expression statement blanked, each changed
module's AST is identical to origin/main's.
fix(const): Method.get is case-insensitive, but RFC 9110 makes the method token case-sensitive #896 and test(const): audit every registry case sensitivity against its source specification #903 modules (RFC text, line 2559).
five; the comment now sums to the table's 21.
fix(protocols)!: keep pack() from rewriting the instance it is called on (#1769) #1791, building on _packing_target(); the MPTCP stale-flags case says
make, which it calls.
files, into protocol.py, frame.py, field.py, byteorder.py, the five
UnsupportedCall sites, tcp.py, ipv6.py, extension_header.py, the
pcapng schema, apptype.py and vendor/main.py.
Refs #1103