Repository navigation
refactor(vendor): keep the vendor variables in pcapkit.vendor (#1726) - #1745
Merged
Merged
Conversation
Owner
Author
|
Verdict: GOOD TO GO at
|
Owner
Author
|
Verdict: NEEDS CHANGES at |
The crawlers' variables move back out of pcapkit.utilities.config, which now holds the tunable limits only. - Restore pcapkit.vendor.default.MAX_RETRY (PCAPKIT_VENDOR_RETRY, default 5, minimum 1) and CI_MODE (PCAPKIT_CI_MODE) under their 1.4.x names, and drop #1743's versionremoved notes for them. - Read them with config.read_limit and config.read_flag, made public from _read_limit and _read_flag, so a bad value still warns with ConfigWarning, naming the variable and the value, and falls back. - get_proxies() reads PCAPKIT_HTTP_PROXY and PCAPKIT_HTTPS_PROXY itself on every call. config.VENDOR_RETRY, CI_MODE, http_proxy and https_proxy never shipped, so they are removed outright. - Document the four variables on the pcapkit.vendor.default page, which config.rst and index.rst link to. - Move #1743's vendor tests to tests/vendor/test_vendor_variables_1726_unit.py, and run it in project-tests' docs-only step, since it reads the docs. Refs #1726
JarryShaw
force-pushed
the
refactor/1726-vendor-vars-stay-in-vendor
branch
from
October 14, 2026 23:21
8c525c0 to
e41eaf0
Compare
Owner
Author
|
Verdict: GOOD TO GO at
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change. Narrow runs only, listed below.Added a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseRefs #1726. This follows the owner's later ruling that the vendor variables stay in
pcapkit.vendor, which reverses the part of #1743 that moved them.pcapkit.vendor.default.MAX_RETRY(PCAPKIT_VENDOR_RETRY, default 5, minimum 1) andCI_MODE(PCAPKIT_CI_MODE) are back under their 1.4.x names. feat(utilities)!: one config module for the tunable limits (#1726) #1743'sversionremovednotes for them are gone.config.read_limitandconfig.read_flag, the newly public_read_limitand_read_flag. A bad value warns withConfigWarningand falls back, where 1.4.x crashed on a non-integer and read0as1.get_proxies()readsPCAPKIT_HTTP_PROXYandPCAPKIT_HTTPS_PROXYitself, on every call.config:VENDOR_RETRY,CI_MODE,http_proxyandhttps_proxy. They never shipped, so they are deleted outright with no re-export.pcapkit.vendor.defaultpage, andconfig.rstlinks there. Sphinx warnings are identical tomain.tests/vendor/test_vendor_variables_1726_unit.py. Their notices, both retry loops and the per-call proxy reads are all kept.