Repository navigation
fix(internet): a cut leaving only the type octet of a CALIPSO, SMF_DPD or MPL option logs a FieldValueError #2727
Description
Found by the Sonnet review of the #2694 fix. The same behaviour is on main at 01f063467, so this is not a regression.
A capture cut that leaves only the type octet of a CALIPSO, SMF_DPD or MPL option in HOPOPT or IPv6-Opts logs FieldValueError: … invalid <X> option length: 0. Inside IPv6 it logs at CRITICAL, plus a WARNING, though the layer is kept. Their length callbacks in the IPv6 option schemas reject the zero-filled length. A cut one octet later is clean.
Under the short-read ruling, a cut should be recorded quietly through Schema's built-in, so a cut at 3 octets should behave like a cut at 4. The pins in test_ipv6_option_helpers_1519_unit, test_ipv6_extension_unit and test_dead_branches_2318_unit hold the current error and will move with the fix.
This is blocked until #2694 merges, because it reworks the same option areas.
Activity
JarryShaw commentedon Nov 3, 2026
#2694 (#2731) has merged as
ab7be2fb0, so this is unblocked. A worker goes on it next.wip.JarryShaw commentedon Nov 3, 2026
The PR is #2737.
fix(internet)!: read a cut after an IPv6 option's type octet as a sho…
fix(protocols): report a rebuilt frame's messages once and record cut…
fix(protocols): report a rebuilt frame's messages once and record cut…