Skip to content

fix(cli): the -o/--output help text describes the input file #1796

Closed

Description

@JarryShaw

Describe the bug
In pcapkit/__main__.py:53, the -o/--output help text reads "The name of input pcap file. If format extension omits, it will be automatically appended.", copied from the positional input argument at :49. docs/source/pcapkit/index.rst:93 mirrors it.

Expected behavior
The help text describes the output file, and the docs page matches it.

Additional context
Found by the #1103 second pass (docs slice). A string change in code, so it is out of scope for the prose sweep.

Activity

  1. added
    fixPull requests that fix a defect (fix: subject prefix)
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 15, 2026
  2. JarryShaw commented on Oct 15, 2026

    @JarryShaw
    OwnerAuthor

    Blocked until #1802 merges; it edits docs/source/pcapkit/index.rst, which this fix also changes.

  3. added
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    and removed
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 15, 2026
  4. JarryShaw commented on Oct 15, 2026

    @JarryShaw
    OwnerAuthor

    Unblocked: #1802 has merged. A worker is on it.

  5. added
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    on Oct 15, 2026
  6. JarryShaw commented on Oct 15, 2026

    @JarryShaw
    OwnerAuthor

    Scope widened to the same defect in two neighbouring help strings: the positional input help says ".pcap" is appended, and the -a/--auto-extension help names only the output. Both behaviours happen only with -a (Extractor.make_name), and both are fixed in the same PR.

  7. removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    fixPull requests that fix a defect (fix: subject prefix)

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions