Skip to content

chore: three MANIFEST.in lines match nothing #1794

Closed

Description

@JarryShaw

Describe the bug
Three MANIFEST.in lines have no effect. Each was checked by building sdists with and without the line; the listings are identical (1248 entries).

  • :3 global-include *.rst: no tracked .rst outside docs/ ships since chore: drop stale build leftovers and move the examples' READMEs to Markdown (#1773) #1780; the 37 shipped .rst files come from the recursive-include of docs/source/changelog.
  • :88 include pcapkit/_extern: include matches files, not a directory; every build warns no files found matching. This holds even with a fake _extern tree present, as in the conda build.
  • :89 exclude pcapkit/protocols/*/NotImplemented: matches nothing; every build warns no previously-included files found, and all 37 NotImplemented paths ship either way.

Expected behavior
Each line either does what it says or is removed, and the build warnings go away. docs/source/contributing/conventions/documentation.rst:270-278, which records that the placeholders ship, should still agree.

Additional context
Found by the #1103 second pass (repo slice) and confirmed by a Sonnet review.

Activity

  1. added
    choreMaintenance work: tooling, repo hygiene, no library behaviour change
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 15, 2026
  2. JarryShaw commented on Oct 15, 2026

    @JarryShaw
    OwnerAuthor

    Blocked until #1802 and #1804 merge; they edit documentation.rst and MANIFEST.in, which this fix also changes.

  3. added
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    and removed
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 15, 2026
  4. JarryShaw commented on Oct 15, 2026

    @JarryShaw
    OwnerAuthor

    Unblocked: #1802 and #1804 have merged. A worker is on it.

  5. added
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    on Oct 15, 2026
  6. removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    choreMaintenance work: tooling, repo hygiene, no library behaviour change

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions