chore: three MANIFEST.in lines match nothing #1794
Copy link
Copy link
Closed
Labels
choreMaintenance work: tooling, repo hygiene, no library behaviour changeMaintenance work: tooling, repo hygiene, no library behaviour change
Description
Describe the bug
Three MANIFEST.in lines have no effect. Each was checked by building sdists with and without the line; the listings are identical (1248 entries).
:3global-include *.rst: no tracked.rstoutsidedocs/ships since chore: drop stale build leftovers and move the examples' READMEs to Markdown (#1773) #1780; the 37 shipped.rstfiles come from therecursive-includeofdocs/source/changelog.:88include pcapkit/_extern:includematches files, not a directory; every build warnsno files found matching. This holds even with a fake_externtree present, as in the conda build.:89exclude pcapkit/protocols/*/NotImplemented: matches nothing; every build warnsno previously-included files found, and all 37NotImplementedpaths ship either way.
Expected behavior
Each line either does what it says or is removed, and the build warnings go away. docs/source/contributing/conventions/documentation.rst:270-278, which records that the placeholders ship, should still agree.
Additional context
Found by the #1103 second pass (repo slice) and confirmed by a Sonnet review.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
choreMaintenance work: tooling, repo hygiene, no library behaviour changeMaintenance work: tooling, repo hygiene, no library behaviour change
Projects
- StatusShow more project fieldsDone
Activity
JarryShaw commentedon Oct 15, 2026
Blocked until #1802 and #1804 merge; they edit
documentation.rstandMANIFEST.in, which this fix also changes.JarryShaw commentedon Oct 15, 2026
Unblocked: #1802 and #1804 have merged. A worker is on it.
chore: drop the MANIFEST.in lines that match nothing (#1794) (#1813)