Skip to content

refactor(protocols): one home per duplicated RFC-fixed constant (#1726 ruling 7) #1739

Closed

Description

@JarryShaw

Is your feature request related to a problem? Please describe.
Ruling 7 on #1726: RFC-fixed protocol constants that are duplicated across modules get one home, the module that owns the protocol, and they are never made configurable. The config-module PR leaves this for a follow-up, because both edit the same toolkit files.

Duplicates found by #1726's worker and its review (lines on d06701064):

  • toolkit/pypcapfile.py:85,94,97: TCP_MIN_HEADER_LEN = 20, IPV4_HEADER_LEN, IPV6_HEADER_LEN = 40
  • toolkit/pcap.py:178: a bare 20
  • foundation/reassembly/ipv6.py:27: _IPV6_HDR_LEN = 40
  • foundation/reassembly/ip.py:35: _MAX_LENGTH = 65535
  • the µs/ns resolution literals, the PCAP and PCAP-NG magics, and the PCAP-NG minimum-block tables

Describe the solution you'd like
Inventory every duplicate, give each a single home in the owning protocol module, and point readers at that home. Removing an old name is breaking and gets a versionremoved directive.

Blocked until
The #1726 config PR merges.

Activity

  1. added
    refactorRestructuring for its own sake — neither a fix nor a new capability (refactor: prefix)
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    on Oct 14, 2026
  2. moved this to Blocked in PyPCAPKiton Oct 14, 2026
  3. JarryShaw commented on Oct 14, 2026

    @JarryShaw
    OwnerAuthor

    #1743 has merged, so this is unblocked. A worker is on it.

  4. added
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    on Oct 14, 2026
  5. moved this from Blocked to WIP in PyPCAPKiton Oct 14, 2026
  6. removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    refactorRestructuring for its own sake — neither a fix nor a new capability (refactor: prefix)

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions