feat: allow data links for files#385
Open
allison-truhlar wants to merge 6 commits into
Open
Conversation
Validate proxied paths for any existing, accessible target: regular files (os.access) and directories (os.listdir), as well as symlinks to either. Symlinks are not special-cased on creation — a symlink whose target exists is a valid data link target; broken symlinks are still rejected via the existence check. Applies to both the in-process validator (database._validate_proxied_path) and the multi-user worker action (user_worker validate_proxied_path).
…and dialog Show the create/delete data-link controls for any path — directories, regular files, and symlinks — rather than directories only. Add a file-specific usage tab to the data link dialog. The properties drawer no longer gates data-link controls on the target being a non-symlink.
Assert _validate_proxied_path and create_proxied_path accept regular files and symlinks to valid targets, reject broken symlinks (as nonexistent), and that the worker validate_proxied_path action accepts files and symlinks while still 400ing on missing paths.
Cover the data link usage dialog and the properties-drawer data-link controls for regular-file and symlink targets, asserting the create toggle and 'Learn more' link render for both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clickup id: 86acm7dp5
This PR allows the creation of data links for files. Previously, data link creation was limited to directories only.
@krokicki