fix: data links at the file share path root#384
Open
allison-truhlar wants to merge 3 commits into
Open
Conversation
When the file browser is at the FSP root, Filestore returns "." as the relative path. A literal "." in a share URL gets collapsed by URL normalization at the recipient, causing path mismatch / NoSuchBucket errors when the link is opened. This fix: - Normalizes "." -> "" on write and on read in the backend API endpoints - Adds a _normalize_proxied_path helper and dot-segment validation to _validate_url_prefix (and matching frontend validateUrlPrefix) - Falls back to the FSP name when deriving a url_prefix from an empty path - Handles legacy DB records with stored path="." in the proxy resolver - Mirrors the same normalization in the DataLink dialog preview
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the file browser is at the FSP root, Filestore returns "." as the relative path. A literal "." in a share URL gets collapsed by URL normalization at the recipient, causing path mismatch / NoSuchBucket errors when the link is opened. This fix:
When merged, closes issue #368
@krokicki