Repository navigation
Conversation
gigitux
marked this pull request as ready for review
October 3, 2026 13:24
Open
1 task done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (What)
Fixes #342
Report YAML parse errors when loading
pnpm-workspace.yaml, including the parser’s reason, line, and column. Adds a test covering invalid YAML and preservation of the original error.Justification (Why)
Invalid workspace YAML was silently ignored, allowing Syncpack to continue without the workspace configuration. This change stops execution and surfaces the error so users can fix it.
How Can This Be Tested?
cargo test parse_yaml_file_strict_returns_error_for_invalid_yaml.pnpm-workspace.yamland confirm it reports the parsing error.