fix(scripts): grade export class/enum in dead-exports check - #10154
Conversation
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-31 10:16:29 UTC
Review summary Nits — 3 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Extend EXPORTED_RUNTIME_SYMBOL to match class, abstract class, enum, and const enum so runtime type-like exports are graded like const/function. Closes JSONbored#10047 Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10154 +/- ##
=======================================
Coverage 92.05% 92.05%
=======================================
Files 931 931
Lines 114046 114046
Branches 27543 27543
=======================================
Hits 104988 104988
Misses 7759 7759
Partials 1299 1299
Flags with carried forward coverage won't be shown. Click here to find out more. |
Summary
Closes #10047
Test plan
pm run dead-exports:check exits 0