docs(ci): record why the escalation job's setup-node scan finding was dismissed - #10153
Merged
Conversation
… dismissed A scanner flagged actions/setup-node in the escalate-persistent-failure job (#10146) as a filesystem-read risk, citing __tests__/authutil.test.ts. That is a test fixture inside setup-node's own repository, not runtime behaviour, and the feature it exercises -- writing an auth token into .npmrc -- only engages when `registry-url` is supplied. It is supplied in the five publish-*.yml workflows and deliberately not here, so the path is inert in this job. The pin is also the same SHA as all 32 other setup-node uses in the repo, including build-boot in this same file, so the job introduced no dependency that was not already present. No behaviour change -- the finding was reviewed and dismissed, and the reason is recorded here so the next scan does not cost another investigation. The note names the condition that would invalidate it (this step gaining registry-url) rather than dismissing the rule outright.
Contributor
|
Important 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏳ LoopOver is waiting…LoopOver has seen this pull request and is waiting on CI checks to finish before reviewing it. This comment will update once the review runs. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟨 Waiting |
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10153 +/- ##
===========================================
+ Coverage 80.13% 92.05% +11.92%
===========================================
Files 282 931 +649
Lines 58742 114046 +55304
Branches 6963 27543 +20580
===========================================
+ Hits 47070 104989 +57919
+ Misses 11381 7759 -3622
- Partials 291 1298 +1007
Flags with carried forward coverage won't be shown. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #10147 (comment-only, no behaviour change).
A security scanner flagged
actions/setup-nodein the newescalate-persistent-failurejob as a filesystem-read risk (P1), citing__tests__/authutil.test.ts.Reviewed and dismissed. The evidence:
authutil.test.tslives inside setup-node's own repository and exercises its.npmrcauth-token feature. Test files in an action's repo do not execute when the action runs.registry-urlis supplied. In this repo that happens in exactly five places — allpublish-*.yml— and deliberately not here. This step passes onlynode-version-file, so setup-node never touches.npmrcor any credential path.setup-nodeuses in the repo, includingbuild-bootin this same file. The job introduced no dependency that was not already present.The job is also already minimal:
persist-credentials: falseon checkout, permissions scoped tocontents: read+issues: write, nonpm ci, and a script whose only import isnode:child_process.This PR records that reasoning at the call site so the next scan does not cost another investigation — and names the condition that would invalidate it (this step gaining
registry-url) rather than dismissing the rule outright.