fix(engine): add the missing documentation_url snake_case alias, derive the urlFields pairing test - #10149
Conversation
…ve the urlFields pairing test urlFields/sourceUrlFields carried snake_case aliases for eight of the nine camelCase URL fields; documentationUrl had none, so a submitted entry spelled documentation_url was invisible to both duplicate detection and the source-evidence fetch-verification gate. The regression test that was supposed to pin the pairing invariant enumerated the aliases by hand instead of deriving them from the set, so it couldn't have caught the gap in the first place.
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-31 09:49:21 UTC
Review summary Nits — 3 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10149 +/- ##
===========================================
+ Coverage 80.13% 92.20% +12.07%
===========================================
Files 282 931 +649
Lines 58742 114036 +55294
Branches 6963 27537 +20574
===========================================
+ Hits 47070 105150 +58080
+ Misses 11381 7584 -3797
- Partials 291 1302 +1011
Flags with carried forward coverage won't be shown. Click here to find out more.
|
fix(engine): add the missing documentation_url snake_case alias, derive the urlFields pairing test
urlFields/sourceUrlFields carried snake_case aliases for eight of the nine camelCase URL fields;
documentationUrl had none, so a submitted entry spelled documentation_url was invisible to both
duplicate detection and the source-evidence fetch-verification gate. The regression test that was
supposed to pin the pairing invariant enumerated the aliases by hand instead of deriving them from
the set, so it couldn't have caught the gap in the first place.
Closes #9992