Skip to content

fix(engine): add the missing documentation_url snake_case alias, derive the urlFields pairing test - #10149

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
bitfathers94:fix/issue-9992
Jul 31, 2026
Merged

fix(engine): add the missing documentation_url snake_case alias, derive the urlFields pairing test#10149
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
bitfathers94:fix/issue-9992

Conversation

@bitfathers94

Copy link
Copy Markdown
Contributor

fix(engine): add the missing documentation_url snake_case alias, derive the urlFields pairing test

urlFields/sourceUrlFields carried snake_case aliases for eight of the nine camelCase URL fields;
documentationUrl had none, so a submitted entry spelled documentation_url was invisible to both
duplicate detection and the source-evidence fetch-verification gate. The regression test that was
supposed to pin the pairing invariant enumerated the aliases by hand instead of deriving them from
the set, so it couldn't have caught the gap in the first place.

Closes #9992

…ve the urlFields pairing test

urlFields/sourceUrlFields carried snake_case aliases for eight of the nine camelCase URL fields;
documentationUrl had none, so a submitted entry spelled documentation_url was invisible to both
duplicate detection and the source-evidence fetch-verification gate. The regression test that was
supposed to pin the pairing invariant enumerated the aliases by hand instead of deriving them from
the set, so it couldn't have caught the gap in the first place.
@bitfathers94
bitfathers94 requested a review from JSONbored as a code owner July 31, 2026 09:20
@loopover-orb

loopover-orb Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Tip

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-31 09:49:21 UTC

4 files · 1 AI reviewer · no blockers · readiness 98/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This is a small, well-scoped fix that adds the missing `documentation_url` snake_case alias to `urlFields` and `sourceUrlFields` in `content-repo-spec.ts`, closing a real gap where a submitted `documentation_url` entry was invisible to duplicate detection and the source-evidence gate. The PR also replaces the previously hand-enumerated pairing test with a derived assertion that walks every camelCase `urlFields` member and checks its snake_case counterpart exists in both sets, which is a genuine improvement since the old test literally couldn't catch this class of regression. Regression tests are added at both the unit level (duplicates, source-evidence) and a new `content-repo-spec.test.ts` that imports from `dist/`, which is worth a quick sanity check but not a blocker since CI passed.

Nits — 3 non-blocking
  • packages/loopover-engine/test/content-repo-spec.test.ts:4 imports from `../dist/review/content-lane/content-repo-spec.js` rather than the TS source under `src/`, unlike the other two test files which import from `../../src/...` — worth confirming this is the established convention for this package's test suite rather than an inconsistency.
  • The derived pairing-assertion loop is now duplicated near-verbatim in three places (content-repo-spec.test.ts, content-lane-duplicates.test.ts's protectedFrontmatterFields test, and content-lane-source-evidence.test.ts's urlFields test) — consider factoring the `toSnakeCase` derivation into a shared test helper to avoid drift between the three copies.
  • Consider extracting the repeated `toSnakeCase`/pairing-walk logic into a shared test utility so future spec fields only need one assertion updated instead of three.

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #9992
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 119 registered-repo PR(s), 82 merged, 3 issue(s).
Contributor context ✅ Confirmed Gittensor contributor bitfathers94; Gittensor profile; 119 PR(s), 3 issue(s).
Improvement ✅ Minor risk: clean · value: minor · LLM: moderate
Linked issue satisfaction

Addressed
The diff adds "documentation_url" to both urlFields and sourceUrlFields in the correct snake_case block position, and replaces the hand-enumerated alias loop in content-lane-source-evidence.test.ts with a derived loop over urlFields that mirrors the toSnakeCase pattern from content-lane-duplicates.test.ts, exactly as required.

Review context
  • Author: bitfathers94
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: TypeScript
  • Official Gittensor activity: 119 PR(s), 3 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Keep the PR focused and include validation evidence before maintainer review.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 31, 2026
@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.20%. Comparing base (8f46e72) to head (bed280b).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #10149       +/-   ##
===========================================
+ Coverage   80.13%   92.20%   +12.07%     
===========================================
  Files         282      931      +649     
  Lines       58742   114036    +55294     
  Branches     6963    27537    +20574     
===========================================
+ Hits        47070   105150    +58080     
+ Misses      11381     7584     -3797     
- Partials      291     1302     +1011     
Flag Coverage Δ
backend 95.67% <ø> (?)
engine 73.77% <100.00%> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ngine/src/review/content-lane/content-repo-spec.ts 100.00% <100.00%> (+100.00%) ⬆️

... and 781 files with indirect coverage changes

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit 9383b83 into JSONbored:main Jul 31, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

engine(content-lane): add the missing documentation_url snake_case alias and make the urlFields pairing assertion derived

1 participant