fix(api): validate discovery routes against published schemas - #10148
Closed
andriypolanski wants to merge 2 commits into
Closed
fix(api): validate discovery routes against published schemas#10148andriypolanski wants to merge 2 commits into
andriypolanski wants to merge 2 commits into
Conversation
Single-source FindOpportunities and IssueRag request bodies from @loopover/contract, enforce them on REST before hand-rolled checks, and stop silent truncation of over-long labels/body. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Important 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏳ LoopOver is waiting…LoopOver has seen this pull request and is waiting on CI checks to finish before reviewing it. This comment will update once the review runs. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟨 Waiting |
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
❌ 3 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
…lidation Update validateIssueRagInput and route rejection expectations so length bounds live on RetrieveIssueContextInput and empty/malformed bodies map to invalid_body, matching the discovery schema gate. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
This repository reviews pull requests one-shot: the PR must be correct as originally opened. Pushing an additional commit closes it automatically instead of restarting review — open a fresh pull request with every fix included. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FindOpportunitiesRequestSchema/IssueRagRetrieveRequestSchemafrom@loopover/contract'sFindOpportunitiesInput/RetrieveIssueContextInput(single source for MCP, REST, OpenAPI).invalid_request+reasonshapes..min(1)onRetrieveIssueContextInputowner/repo/title; stop silent truncation of over-longlabels/body; document the cross-fieldtargets/searchQueryrule on the OpenAPI operation.Test plan
npx vitest run test/unit/find-opportunities.test.ts test/unit/mcp-issue-rag.test.ts test/unit/mcp-find-opportunities.test.ts test/unit/contract-registry.test.ts test/unit/openapi.test.tsnpx vitest run test/integration/api.test.ts -t "REGRESSION: discovery routes"npm run ui:openapiFixes #10040