Cleanded up commit history - #6
Open
Srinandha-Murugesan wants to merge 14 commits into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Srinandha-Murugesan
force-pushed
the
19773-fixed
branch
2 times, most recently
from
July 30, 2026 18:58
f45069a to
349aa78
Compare
Signed-off-by: Anders Kaseorg <anders@zulip.com>
… the only possible return value. Signed-off-by: Anders Kaseorg <anders@zulip.com>
…g methods. Signed-off-by: Anders Kaseorg <anders@zulip.com>
…ption` call. Signed-off-by: Anders Kaseorg <anders@zulip.com>
Signed-off-by: Anders Kaseorg <anders@zulip.com>
Signed-off-by: Anders Kaseorg <anders@zulip.com>
We missed to set this flag in the original implementation of the self-serve flow - but there's no reason not to enable the conversion of threads.
Commit 0cd5c18 refactored the reply-button label to use a template that consumes the structured fields (stream, topic_display_name, has_empty_string_topic) directly, and dropped the now-redundant label_text for stream/topic recipients. However, label_text is still consumed by the BigBlueButton and Nextcloud Talk call-creation paths in compose_call_ui.ts Restore the label_text field for stream/topic recipients using the same format the refactor removed.
When testing for the logging output was improved in these stripe billing tests, duplicate calls to get the CustomerPlan object were added to multiple tests. Removing that duplication simplifies these tests and removes any confusion about whether the different plan variables are the same or different plans. Also removes any confusion via variable names that the logging output contains Stripe.customer IDs, when they in fact contain the IDs of our database's Customer objects.
Update WebhookTestCase to inject test secrets and build signature headers automatically. Enable signature validation in GitHub webhooks to reject invalid payloads early, and simplify test setup for future integrations. Co-authored-by: Srinandha Murugesan <srinandhamurugesan@gmail.com> Co-authored-by: Isaiah Marte <JDoe-code@users.noreply.github.com> Co-authored-by: Akshaj Katkuri <Akshaj-Katkuri@users.noreply.github.com> Co-authored-by: Jason Zheng <jasonzheng13@users.noreply.github.com>
Add UI for adding a webhook secret in the add bot form and modifying or deleting it in the manage bot form. This allows for secure storage of secrets in BotConfigData over URL parameters and lets users modify it as needed. Co-authored-by: Srinandha Murugesan <srinandhamurugesan@gmail.com> Co-authored-by: Isaiah Marte <JDoe-code@users.noreply.github.com> Co-authored-by: Akshaj Katkuri <Akshaj-Katkuri@users.noreply.github.com> Co-authored-by: Jason Zheng <jasonzheng13@users.noreply.github.com>
Add a UI field and backend endpoint to the integrations dev panel to type a secret and dynamically calculate signature headers for fixture payloads. This allows developers to test signature verification in webhook endpoints directly through fixture mock requests. Co-authored-by: Srinandha Murugesan <srinandhamurugesan@gmail.com> Co-authored-by: Isaiah Marte <JDoe-code@users.noreply.github.com> Co-authored-by: Akshaj Katkuri <Akshaj-Katkuri@users.noreply.github.com> Co-authored-by: Jason Zheng <jasonzheng13@users.noreply.github.com>
Srinandha-Murugesan
force-pushed
the
19773-fixed
branch
from
July 31, 2026 16:20
c5f8500 to
a3f9305
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidated commit history into 5 commits