Last Major Bugfix - #3469
Conversation
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
boop |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
boop+ |
|
just gonna prevent staling |
If you manually purchase, you can only get 1 shy of 3.3 million purchases. This means you don't trigger the ee6 and miss out on about e7000x to IP, which isn't much but still
changes 2e404 -> 2.00e404 and 1 Realities -> 1.1 Realities (yes we were doing 0 decimal places idk why)
On potential glyphs, the x% uses (what i presume is) the old color code, and so wont swap with contrast colors.
Add comment as to why we dont contrast (tl;dr pointless)
HexaVault
changed the title
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
anti stale |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
destale |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
…time, disable DAB when doomed
… beaten atleast once
…it being on a locked currency, or displaying END after reset
…ige< breaking --- code from IvarK#3392
… 2 offline ui modals, achievement count is now correctly colored in away entry
…ularities no longer causes singularity section to be slighly wider than section below.
Run `stylelint --fix` across public/stylesheets and src/**/*.vue using the repo's pinned stylelint 14.8.2 config, and hand-fix the four remaining issues it can't autofix. All 157 issues were pre-existing on master; this PR introduced none of them. Most of CodeFactor's warnings (rgba→rgb, -webkit-* prefixes) come from it running a newer stylelint that ignores this repo's config, which explicitly allows those, so they are not addressed here. Autofixed (153): - order/properties-order: reorder declarations per .stylelintrc.json (147) - color-hex-length / color-hex-case: IvarK#333 → #333333, #A2A229 → #a2a229 - max-empty-lines, no-missing-end-of-source-newline Manual (4): - styles.css: merge duplicated `.infotooltip:hover .infotooltiptext` rule - styles.css: remove `.c-modal-IAP__warning` — unused anywhere in src/ or public/, and violates the kebab-case class pattern - .stylelintignore: add vendored github-light.css (GitHub 2014 stylesheet) alongside fontawesome/codemirror/vis-network No CSS values changed beyond hex normalization. ESLint output is identical before and after (199 pre-existing problems, untouched). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…d sidebar handling for when new currencies are unlocked, fixed deleting companion not deleting the right one
| } | ||
|
|
||
| if (player.sidebarCurrencyUnlocks << 2 % 2 === 0) { | ||
| if (player.sidebarCurrencyUnlocks >> 2 % 2 === 0) { |
There was a problem hiding this comment.
Ok now the Crunch and Replicanti sites work, but this site doesn't. I tested with player.sidebarCurrencyUnlocks at 3. Console confirms that player.sidebarCurrencyUnlocks >> 2 % 2 === 0 is false.
There was a problem hiding this comment.
Yes because 3 >> 2 is 0.
There was a problem hiding this comment.
3 >> 2 % 2 is 3, but (3 >> 2) % 2 is 0
There was a problem hiding this comment.
ah order of operations being dumb
will fix in ~20 or so
4 participants
Changes:
Fixes Sacrifice stating it is automated when it is not
Fixed an achievement stating galaxies, rather than antimatter galaxies
Fixed 2xIP being just ever so slightly off if you buy it one at a time close to the cap, preventing from getting the extra boost to make it a neat 1e1,000,000x multiplier
Fixed the Prestiges in the prestige runs tab rounding to 0 decimal places, causing 1.1 realities -> 1 realities.
Fixed some cases of contrast color explictly not being used
Prevent being able to reality with less than 5000 RM while having Synthetic Symbolism lock active.
Fixed EM200/1000 working in Pelle.
ts192 now removes its strikethrough to show that it works, when the vacuum milestone is disabled
Text related to vacuum milestone in replicanti tab now properly hides.
Fixed ACHNR bypassing the Paradoxically Attain upgrade lock.
Fixed/Standardised some punctuation
Added a note about galaxies to dimBoostResetsNothing for Pelle.
Fixed the progress bar, which was meant to show progress to galaxy generator, being overriden by dilation "special reality" while doomed
Fixed Dimension Boosts being labelled as Dimensional Boosts
Fixed if statements sometimes skipping in automator
Added a mention of ts192 to h2p for replicanti
Fixed Galaxy Generator displaying "never affordable" by not considering already owned generated galaxies.
Moved Tesseract "content catchup" to be locked behind V, not nameless, to prevent accidentally mentioning unknown mechanics, which would allow you to pre-preemptively access the h2p page for them.
Added "This Reality does not allow Sacrifices" text in Nameless' Reality, as a disabled condition.
Added a note about Nameless disabling Dimensional Sacrifice.
Removed doubleEverything and tripleEverything dev functions (they hardly worked anyways).
Replaced fixSave dev function with a much better, likely to work function.
Added a dev flag to run fixSave on importing broken saves.
Fixed EffectDisplay, under rare conditions, not updating its formatEffect properly
Fixed ec6 entry modal displaying an asterisk rather than jumbled text while in Nameless
Fixed darkFromDilatedTime singularity milestone not mentioning it effects Dark Energy
Added a migration to remove the useless player.infinity
Changed "Transience of Information" imaginary upgrades to have an extra d.p. of precision, such that you can always see the change when purchasing rebuyables.
nc3 is now labelled "3rd Antimatter Dimension Autobuyer Challenge" not "3rd Antimatter Dimension Challenge"
DRP now uses formatMachines
Fixed Antimatter Galaxy text sometimes stating it wouldnt reset things that are reset
Upped max-len from 120 to 140 (140 is fine for most people nowadays, and still generally avoids overloading single lines)
Fixed some RU requirements being prefixed with a number, causing descriptionDisplay to sometimes capitalise numbers inappropriately (i.e. E12.0 rather than e12.0)
Fix automator log stating "undefined attempted" when nowait causes a prestige event to get skipped
Fixed automator UNTIL (ty #3392 )
Fixed blind theme not being handled like Normal theme, resulting in some weird UI
Fixed shift-clicking ecs to see them early
Fixed the nameless sigil being slightly off center
Disabled DAB while doomed
Prevented showing the "First infinity" modal, which states that you can disable animations, on subsequent playthroughs
Achievement 116 now states "more than" rather than "only", to indicate it can be done with 0 infinities.
Stopped spawning 2 offline modals for no reason
When showing offline progress, the Achievement Count is now appropriately flavored
The replicanti galaxy modal now takes into consideration whether r126 can be applied, to account for it being disabled due to Pelle
Fixed <b> tags not causing text to be made bold
Fixed celnav hiding the flavor text stating that "Lai'telas Reality has been Destroyed" if the Pelle upgrade is purchasable or purchased, to make it consistent with other celestial navigation nodes.
The Lai'tela tab no longer has the singularity section of the tab being 2rem wider than the rest of the tab if you have yet to unlock any singularities.
Fixed the gradient number text in the Galaxy Generator being present during blind theme
Fixed a case where having 1 tickspeed upgrade would say "tickspeed upgrades" in the TD tab
Fixed studies being reset before giving banked infinities, leading to some cases where you received none.
Fixed the replicanti galaxy keybind showing Cosmic Conglomerate's lock modal even if you could not buy an RG
Removed useless player objects (infinity.upgradeBits and laitela.upgrades)
Scour to Empower now checks after reality, not before.
Fixed the Decay rift stating you gained 1% of EP every second, rather than 10%
Sidebar "latest resource" now updates upon unlocking a new resource
Deleting a companion glyph will now execute the glyph that was selected, not a random companion.
Note: I don't know how the DRP works so i can't implement it myself, but we need to have an ingame toggle for it.
Also See:
#3481 for buy10 toggleAded#3451 for a multiplier breakdown fix (not included here because is much more complex to check)