fix(dialog): render upgrade categories as interleaved body rows#69
Open
InvisibleSpiders wants to merge 1 commit into
Open
fix(dialog): render upgrade categories as interleaved body rows#69InvisibleSpiders wants to merge 1 commit into
InvisibleSpiders wants to merge 1 commit into
Conversation
Paper dialog body always renders before multiAction buttons, so category headers placed as buttons appeared after all upgrade entries. Switch the upgrade list to clickable body text rows (category header + entry per upgrade), with only the close control remaining as a multiAction button. Fixes #68 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
multiActionbuttons for upgrade entries with clickable body text rows, so category headers can appear immediately before their upgradesmultiActionbuttoncategoryHeadersInterleavedWithUpgradesInSortOrdertest toUpgradeDialogTestRoot Cause
Paper dialog body text always renders before
multiActionbuttons, making it impossible to interleave category dividers with upgrade entries when using buttons for upgrades.Test plan
./gradlew.bat :haven-core:test --tests "dev.invisiblespiders.haven.core.dialog.UpgradeDialogTest"passes:haven-core:testsuite passesCloses #68
🤖 Generated with Claude Code