Repository navigation
Read pool parameters from query pool-state output or a node in stake-pool bls-registration-certificate - #1490
Open
carbolymer wants to merge 3 commits into
Conversation
query pool-state output or a node in stake-pool bls-registration-certificate
carbolymer
force-pushed
the
mgalazyn/feature/bls-registration-certificate-pool-state
branch
from
October 29, 2026 10:53
52dba82 to
11e0e18
Compare
carbolymer
force-pushed
the
mgalazyn/feature/bls-registration-certificate-pool-state
branch
from
October 29, 2026 14:31
11e0e18 to
a4821ea
Compare
carbolymer
marked this pull request as ready for review
October 29, 2026 14:31
carbolymer
requested review from
a team,
Jimbo4350,
disassembler,
kevinhammond and
palas
as code owners
October 29, 2026 14:31
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Jimbo4350
approved these changes
Oct 29, 2026
| , "currentStakeDistribution" .= (nes ^. L.nesStakePoolDistrG) | ||
| ] | ||
|
|
||
| -- TODO: upstream to cardano-ledger next to the ToJSON instance of QueryResultStakePoolState. |
Contributor
There was a problem hiding this comment.
Can you create an issue in the ledger repo and tag Alexey in it?
carbolymer
force-pushed
the
mgalazyn/feature/bls-registration-certificate-pool-state
branch
from
October 29, 2026 15:59
a4821ea to
5074d99
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Closes:
The first PR, now merged, added
cardano-cli dijkstra stake-pool bls-registration-certificate offline, which reads an existing registration certificate:stake-pool bls-registration-certificateto change a pool's BLS key from an existing registration certificate #1489This PR adds the other two parameter sources from the issue, so the pool operator no longer needs the original certificate:
offline --pool-state-file FILE --stake-pool-id POOL_IDreads the output ofquery pool-stateand picks one pool.online --stake-pool-id POOL_IDasks a running node for the pool's parameters, with the same node connection options asquery pool-state.Both take
--current-paramsor--pending-params. The pending choice uses the parameters of the pool's pending update. With--current-params, the offline command also needs--mainnetor--testnet-magic, because thequery pool-stateoutput has no network in the pool's reward account; the online command takes the network from the node connection. The command warns when the new certificate replaces a pending update, and when it cancels a retirement that is scheduled for the pool (the ledger drops a re-registered pool from the retiring list). As before, only the BLS key and its proof of possession change.This PR is stacked on #1478 and can merge only after it. That PR makes
query pool-statereturn the ledgerQueryResultStakePoolStateand pins unreleased cardano-ledger, ouroboros-consensus and cardano-api commits as source-repository-packages.The signing workflow will be documented in the developer portal in a separate PR.
How to trust this PR
Review commit by commit.
Commit 1 adds an orphan
FromJSONinstance in cardano-cli, with a TODO to move it to cardano-ledger next to itsToJSONinstance. A Hedgehog round-trip test covers it.Commit 2 has golden tests for the current and pending parameters, for each warning on its own, and for a missing pool, a pool without a pending update and a malformed file. The test input
files/input/dijkstra/stake_pool/pool_state.jsonhas three pools: one with a pending update, one that is retiring, and one with neither.Commit 3 shares the current or pending selection, the warnings and the errors with commit 2, so those tests cover it too. The node query itself is not tested here, because the test suites run without a node.
Example commands:
cardano-cli dijkstra stake-pool bls-registration-certificate offline --pool-state-file pool-state.json --stake-pool-id POOL_ID --pending-params --bls-signing-key-file bls.skey --out-file pool.certcardano-cli dijkstra stake-pool bls-registration-certificate online --socket-path node.socket --testnet-magic 42 --stake-pool-id POOL_ID --current-params --bls-signing-key-file bls.skey --out-file pool.certChecklist
.changes/