Repository navigation
Add a certificate view command to decode certificates into human-readable form - #1488
Merged
Merged
Conversation
Closed
6 tasks
palas
requested review from
Jimbo4350,
carbolymer,
disassembler and
kevinhammond
as code owners
October 28, 2026 00:56
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Jimbo4350
reviewed
Oct 29, 2026
Jimbo4350
approved these changes
Oct 29, 2026
Jimbo4350
left a comment
Jimbo4350
left a comment
Contributor
There was a problem hiding this comment.
LGTM, couple of suggestions.
Jimbo4350
reviewed
Oct 29, 2026
palas
force-pushed
the
certificate-view
branch
from
October 29, 2026 19:50
a61d5e1 to
cadb2ee
Compare
palas
force-pushed
the
certificate-view
branch
from
October 29, 2026 19:57
cadb2ee to
2dcdf22
Compare
palas
enabled auto-merge
October 29, 2026 20:09
10 of 24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR addresses #1487.
Other than what says in the issue. This PR reuses the code that
transaction viewuses, and it completes and fixes it, in a slightly breaking way. For example, spelling "DRep" with the capital 'R' and removing a spurious space around "anchor".One more thing is that the issue talks about using
-to refer to stdin, this is standard in POSIX, but it is not the usual behaviour incardano-cli, I've implemented that as a separate commit in the functionreadFileOrPipein case we choose to skip that.How to trust this PR
Most code is reused, and it has comprehensive golden tests. But make sure you agree with the changes made to the existing code.
Checklist
.changes/