Add Apple Ad Attribution Kit (AAK) version 1.0 extension#209
Open
joseph-shi-vungle wants to merge 8 commits into
Open
Add Apple Ad Attribution Kit (AAK) version 1.0 extension#209joseph-shi-vungle wants to merge 8 commits into
joseph-shi-vungle wants to merge 8 commits into
Conversation
|
Hi @joseph-shi-vungle - this all makes sense to me. I have two concerns that I would consider blocking in this specification:
|
added 2 commits
May 27, 2026 12:06
Author
|
Hi @AramZS , thanks for the review. I agree with both concerns. The spec should not be tied specifically to iTunes, nor should it assume that iTunes/Apple will be the only app store or platform using this field. The intent is to represent the app’s store identifier in a generic way. I have updated the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
/extensions/community_extensions/Location
Files added under:
extensions/community_extensions/adattributionkit/Testing
References
Checklist