Repository navigation
Conversation
/plot setbiome and plot clears wrote biomes at y = 320, one block above a -64..319 world. WorldEdit's 26.x adapter no longer clamps that which made the issue visible by throwing an ArrayIndexOutOfBoundsException. - Plot#getRegions: the unmerged plot branch used the exclusive getMaxBuildHeight() as the inclusive region top. The merged plot branch already subtracts 1 (IntellectualSites#3935). - BukkitQueueCoordinator#enqueue: biome layers were read back without getMinSection(), unlike blocks, so queued biomes landed 64 blocks too high. Clears never reset biomes below y 0, and the top layers were written outside the world. Fixes IntellectualSites#4937
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Both changes correctly restore documented height and section-offset semantics.
0 open findings
What changed in this PR
Fixes out-of-range biome writes in extended-height worlds.
Changes:
- Uses an inclusive maximum Y for unmerged plot regions.
- Restores the minimum-section offset when dequeuing biome writes.
| File | Description |
|---|---|
Core/.../Plot.java |
Corrects the plot region’s upper Y bound. |
Bukkit/.../BukkitQueueCoordinator.java |
Correctly reconstructs biome Y coordinates. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #4937
Description
/plot setbiome and plot clears wrote biomes at y = 320, one block above a -64..319 world. WorldEdit's 26.x adapter no longer clamps that which made the issue visible by throwing an ArrayIndexOutOfBoundsException.
Submitter Checklist
@since TODO.