Remove block entities on server thread#3564
Open
HaHaWTH wants to merge 1 commit into
Open
Conversation
Member
|
Relevant: #3152 |
Member
|
Also #3543 I think |
Author
|
Workaround for log spam: set the |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Overview
Fix unsafe async block entity removal in Paperweight chunk write adapters.
Description
This PR fixes an issue where PaperweightGetBlocks#internalCall could remove block entities directly while running on FAWE queue worker threads.
Previously, when an edit replaced blocks in a chunk, existing block entities were removed immediately during chunk processing via LevelChunk#removeBlockEntity or the Paper beacon removal path. As the backing
blockEntitiesmap is not designed for concurrent writes, this can cause backing map corruption.Existing Issues
After removing BEs in the final sync tasks, this may spam logs like
Block entity A @ BlockPos state Block{B}[facing=north,type=single,waterlogged=false] invalid for ticking:as the removal happens after the chunk section swap.I am not sure whether the preferred long-term fix is to:
Feedback would be appreciated here, especially around the expected ordering between block entity removal, beacon deactivation events, and the chunk section replacement performed by internalCall.
Submitter Checklist
@since TODO.