Conversation
Replace the setup.py build (which uses skbuild.setuptools_wrap internals) with scikit-build-core, and versioneer with setuptools-scm. Closes IntelPython#2341. Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
henryiii
requested review from
antonwolfy,
ndgrigorian and
vlad-perevezentsev
as code owners
September 28, 2026 16:04
|
Can one of the admins verify this patch? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's some potential suggestions based on #2345, you can update that one or go from this one. This uses setuptools-scm. I don't have a setup to test locally.
🤖 AI text below 🤖
Closes #2341. This PR starts from current master and uses #2345 as a reference.
setup.pyis removed. The oldsetup.pyused internals ofskbuild.setuptools_wrapthat are not in scikit-build 1.0.0.23.0.dev401+g<hash>. This is PEP 440, and each new commit gives a higher version..git_archival.txtmakesgit archivetarballs get a version too.tests/_c_ext.candapis/include/*.h, are forced into the sdist.cython_transpilefrom cython-cmake.dpctl-config.cmakestill goes to<prefix>/lib/cmake/dpctl.python-build,wheel,cmakeandninjadirectly. Build dpctl withscikit-build-core#2345 failed because they were missing.build_locally.py,gen_coverage.py,gen_docs.py) usepip install [-e], each with its own build directory.backfill-docs.ymlis not changed, because it builds old tags that still havesetup.py.I tested the Cython transpile step and the wheel and sdist contents locally. I have no SYCL compiler, so CI runs the first full build. The coverage and docs scripts are the parts most likely to need changes. Please check that the new version format works with your internal CI.