chore(deps): bump wasmtime + wasmtime-wasi to 47.0.2 together - #451
Merged
Conversation
Dependabot opened these as two PRs (#447, #448), and neither can land on its own: the crates share a version line, so bumping one leaves `wasmtime::component::ResourceTable` and `wasmtime_wasi::ResourceTable` as two distinct types and the plugin host stops compiling. Both CI runs failed on exactly that, plus a `Linker<_>` mismatch from the same split. Bumped together from a clean main (not from either Dependabot branch, which would drag along their stale lockfiles). No source change was needed — 46 -> 47 is API-compatible for the surface the plugin host uses. Verified: `cargo check --workspace --all-targets` and `cargo test --workspace` (357 tests, incl. the web-radio plugin integration test that actually instantiates a component) both clean. Closes #447 Closes #448 Claude-Session: https://claude.ai/code/session_0153GyoLLYHdHHmqqBHqoXYN
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughLes dépendances optionnelles ChangesMise à niveau des dépendances Wasmtime
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #447 and #448 — closes both.
Why they had to be combined
wasmtimeandwasmtime-wasishare a version line. Dependabot opened one PR each, and neither can land alone: with one crate on 47 and the other on 46,wasmtime::component::ResourceTableandwasmtime_wasi::ResourceTableare two different types and the plugin host stops compiling. Both PRs failed CI on exactly that, plus aLinker<_>mismatch from the same split:Merging either one would have broken
main.What this does
Bumps both to
47.0.2in one commit, branched from a cleanmainrather than from either Dependabot branch — those carry their own stale lockfiles and would have re-downgraded unrelated crates.No source change was needed: 46 → 47 is API-compatible across the surface the plugin host actually uses.
Verification
cargo check --workspace --all-targets— cleancargo test --workspace— 357 passed, 0 failed, includingplugin_web_radio, which really instantiates a WASM component through the new runtime rather than just compiling against it(Exit codes checked directly, not inferred from piped output.)
Summary by CodeRabbit