ci: only release tags publish to WordPress.org - #405
Merged
Conversation
The release trigger was 'on: push: tags: [*]', matching any tag name, so a tag created for a non-release purpose would publish its commit to WordPress.org. That is the exact mechanism that caused the 2026-09-07 incident in InstaWP/instawp-connect, where a tag created only to pin a commit for reference deployed a malicious commit to SVN trunk. This repo was NOT affected by that incident - verified clean on every branch and tag - but it carried the same configuration and the same SVN credentials. Verified against all 13 existing tags: all 13 still match, pre-releases 2.6.0-beta1/beta2 included. 'incident-14ypaj0acdw', 'evidence' and 'wip' do not. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Kilo Code Review could not run — your account is out of credits. Add credits or switch to a free model to enable reviews on this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
trunk-release-tag.ymltriggered onpush: tags: ['*']— any tag name. Combined with theSVN_USERNAME/SVN_PASSWORDrepo secrets, creating a tag for any purpose would publish that commit to WordPress.org.This is not hypothetical. It is the exact mechanism that caused the 2026-09-07 incident in
InstaWP/instawp-connect: a tag namedincident-14ypaj0acdw, created only to pin a commit for reference during an incident, deployed that commit to SVN trunk and the public download served it. See ClickUp 14ypaj0acdw.This repo was not affected — it was just configured the same way
Scanned before making this change, and it is clean:
folderOpen/allowAutomaticTasksanywherevite.config.js,tailwind.config.js,.vscode/or fonts directory at allGitHub <noreply@github.com>with IST offsets — none of the forged−0800committers seen in the incidentIt escaped only because the attacker's script pushed to the repos it had checked out. Nothing about this repo prevented it.
The change
Verification
Checked against all 13 existing tags using GitHub's filter-pattern semantics (
+= one or more of the preceding character,*=[^/]*,.literal):2.6.0-beta1and2.6.0-beta2incident-14ypaj0acdw,evidence,wipYAML re-parsed after the edit; trigger resolves to
['[0-9]+.[0-9]+*'].Known limits, stated rather than discovered later
v-prefixed tags are excluded. No release here has used that form; if that ever changes, add'v[0-9]+.[0-9]+*'.on: push: tags, GitHub runs the workflow file from the tagged commit, not from the default branch. Tagging a commit that predates this merge still executes the old'*'trigger. So the standing rule remains load-bearing: never tag this repo for anything but a release — to pin a commit, use a ref outsiderefs/tags, such asrefs/incident/<name>, which no workflow watches.Engineer (agent-os) · Agentric session: https://aos.agents.instawp.net/#/sessions/cd543281-b08d-413a-8777-4ace3fcb3324