Default-member-initializers, default default-constructors in BinaryMathematicalMorphology

Modules/Filtering/BinaryMathematicalMorphology/include/itkBinaryClosingByReconstructionImageFilter.h

@@ -96,7 +96,7 @@ class ITK_TEMPLATE_EXPORT BinaryClosingByReconstructionImageFilter
   itkBooleanMacro(FullyConnected);
   /** @ITKEndGrouping */
 protected:
-  BinaryClosingByReconstructionImageFilter();
+  BinaryClosingByReconstructionImageFilter() = default;
   ~BinaryClosingByReconstructionImageFilter() override = default;
   void
   PrintSelf(std::ostream & os, Indent indent) const override;
@@ -115,7 +115,7 @@ class ITK_TEMPLATE_EXPORT BinaryClosingByReconstructionImageFilter
   GenerateData() override;
 
 private:
-  InputPixelType m_ForegroundValue{};
+  InputPixelType m_ForegroundValue{ NumericTraits<InputPixelType>::max() };
 
   bool m_FullyConnected{};
 

Modules/Filtering/BinaryMathematicalMorphology/include/itkBinaryClosingByReconstructionImageFilter.hxx

@@ -29,13 +29,6 @@
 
 namespace itk
 {
-
-template <typename TInputImage, typename TKernel>
-BinaryClosingByReconstructionImageFilter<TInputImage, TKernel>::BinaryClosingByReconstructionImageFilter()
-  : m_ForegroundValue(NumericTraits<InputPixelType>::max())
-
-{}
-
 template <typename TInputImage, typename TKernel>
 void
 BinaryClosingByReconstructionImageFilter<TInputImage, TKernel>::GenerateInputRequestedRegion()

Modules/Filtering/BinaryMathematicalMorphology/include/itkBinaryMorphologicalClosingImageFilter.h

@@ -101,7 +101,7 @@ class ITK_TEMPLATE_EXPORT BinaryMorphologicalClosingImageFilter
   itkBooleanMacro(SafeBorder);
   /** @ITKEndGrouping */
 protected:
-  BinaryMorphologicalClosingImageFilter();
+  BinaryMorphologicalClosingImageFilter() = default;
   ~BinaryMorphologicalClosingImageFilter() override = default;
   void
   PrintSelf(std::ostream & os, Indent indent) const override;
@@ -112,9 +112,9 @@ class ITK_TEMPLATE_EXPORT BinaryMorphologicalClosingImageFilter
   GenerateData() override;
 
 private:
-  InputPixelType m_ForegroundValue{};
+  InputPixelType m_ForegroundValue{ NumericTraits<InputPixelType>::max() };
 
-  bool m_SafeBorder{};
+  bool m_SafeBorder{ true };
 }; // end of class
 } // end namespace itk
 

Modules/Filtering/BinaryMathematicalMorphology/include/itkBinaryMorphologicalClosingImageFilter.hxx

@@ -37,12 +37,6 @@
 
 namespace itk
 {
-template <typename TInputImage, typename TOutputImage, typename TKernel>
-BinaryMorphologicalClosingImageFilter<TInputImage, TOutputImage, TKernel>::BinaryMorphologicalClosingImageFilter()
-  : m_ForegroundValue(NumericTraits<InputPixelType>::max())
-  , m_SafeBorder(true)
-{}
-
 template <typename TInputImage, typename TOutputImage, typename TKernel>
 void
 BinaryMorphologicalClosingImageFilter<TInputImage, TOutputImage, TKernel>::GenerateData()

Modules/Filtering/BinaryMathematicalMorphology/include/itkBinaryMorphologicalOpeningImageFilter.h

@@ -99,7 +99,7 @@ class ITK_TEMPLATE_EXPORT BinaryMorphologicalOpeningImageFilter
   itkGetConstMacro(BackgroundValue, PixelType);
 
 protected:
-  BinaryMorphologicalOpeningImageFilter();
+  BinaryMorphologicalOpeningImageFilter() = default;
   ~BinaryMorphologicalOpeningImageFilter() override = default;
   void
   PrintSelf(std::ostream & os, Indent indent) const override;
@@ -110,7 +110,7 @@ class ITK_TEMPLATE_EXPORT BinaryMorphologicalOpeningImageFilter
   GenerateData() override;
 
 private:
-  PixelType m_ForegroundValue{};
+  PixelType m_ForegroundValue{ NumericTraits<PixelType>::max() };
 
   PixelType m_BackgroundValue{};
 }; // end of class

Modules/Filtering/BinaryMathematicalMorphology/include/itkBinaryMorphologicalOpeningImageFilter.hxx

@@ -34,12 +34,6 @@
 
 namespace itk
 {
-template <typename TInputImage, typename TOutputImage, typename TKernel>
-BinaryMorphologicalOpeningImageFilter<TInputImage, TOutputImage, TKernel>::BinaryMorphologicalOpeningImageFilter()
-  : m_ForegroundValue(NumericTraits<PixelType>::max())
-  , m_BackgroundValue(PixelType{})
-{}
-
 template <typename TInputImage, typename TOutputImage, typename TKernel>
 void
 BinaryMorphologicalOpeningImageFilter<TInputImage, TOutputImage, TKernel>::GenerateData()

Modules/Filtering/BinaryMathematicalMorphology/include/itkBinaryMorphologyImageFilter.h

@@ -226,10 +226,10 @@ class ITK_TEMPLATE_EXPORT BinaryMorphologyImageFilter : public KernelImageFilter
 
 private:
   /** Pixel value to dilate */
-  InputPixelType m_ForegroundValue{};
+  InputPixelType m_ForegroundValue{ NumericTraits<InputPixelType>::max() };
 
   /** Pixel value for background */
-  OutputPixelType m_BackgroundValue{};
+  OutputPixelType m_BackgroundValue{ NumericTraits<OutputPixelType>::NonpositiveMin() };
 
   /** Difference sets definition */
   NeighborIndexContainerContainer m_KernelDifferenceSets{};

Modules/Filtering/BinaryMathematicalMorphology/include/itkBinaryMorphologyImageFilter.hxx

@@ -31,8 +31,6 @@ namespace itk
 {
 template <typename TInputImage, typename TOutputImage, typename TKernel>
 BinaryMorphologyImageFilter<TInputImage, TOutputImage, TKernel>::BinaryMorphologyImageFilter()
-  : m_ForegroundValue(NumericTraits<InputPixelType>::max())
-  , m_BackgroundValue(NumericTraits<OutputPixelType>::NonpositiveMin())
 {
   // this->SetNumberOfWorkUnits(1);
   this->AnalyzeKernel();

Modules/Filtering/BinaryMathematicalMorphology/include/itkBinaryOpeningByReconstructionImageFilter.h

@@ -101,7 +101,7 @@ class ITK_TEMPLATE_EXPORT BinaryOpeningByReconstructionImageFilter
   itkBooleanMacro(FullyConnected);
   /** @ITKEndGrouping */
 protected:
-  BinaryOpeningByReconstructionImageFilter();
+  BinaryOpeningByReconstructionImageFilter() = default;
   ~BinaryOpeningByReconstructionImageFilter() override = default;
   void
   PrintSelf(std::ostream & os, Indent indent) const override;
@@ -120,7 +120,7 @@ class ITK_TEMPLATE_EXPORT BinaryOpeningByReconstructionImageFilter
   GenerateData() override;
 
 private:
-  PixelType m_ForegroundValue{};
+  PixelType m_ForegroundValue{ NumericTraits<PixelType>::max() };
 
   PixelType m_BackgroundValue{};
 

Modules/Filtering/BinaryMathematicalMorphology/include/itkBinaryOpeningByReconstructionImageFilter.hxx

@@ -25,13 +25,6 @@
 
 namespace itk
 {
-
-template <typename TInputImage, typename TKernel>
-BinaryOpeningByReconstructionImageFilter<TInputImage, TKernel>::BinaryOpeningByReconstructionImageFilter()
-  : m_ForegroundValue(NumericTraits<PixelType>::max())
-  , m_BackgroundValue(PixelType{})
-{}
-
 template <typename TInputImage, typename TKernel>
 void
 BinaryOpeningByReconstructionImageFilter<TInputImage, TKernel>::GenerateInputRequestedRegion()

Modules/Filtering/BinaryMathematicalMorphology/include/itkBinaryPruningImageFilter.h

@@ -133,7 +133,7 @@ class ITK_TEMPLATE_EXPORT BinaryPruningImageFilter : public ImageToImageFilter<T
   ComputePruneImage();
 
 private:
-  unsigned int m_Iteration{};
+  unsigned int m_Iteration{ 3 };
 }; // end of BinaryThinningImageFilter class
 } // end namespace itk
 

Modules/Filtering/BinaryMathematicalMorphology/include/itkBinaryPruningImageFilter.hxx

@@ -29,7 +29,6 @@ namespace itk
  */
 template <typename TInputImage, typename TOutputImage>
 BinaryPruningImageFilter<TInputImage, TOutputImage>::BinaryPruningImageFilter()
-  : m_Iteration(3)
 {
   this->SetNumberOfRequiredOutputs(1);
 

Modules/Filtering/BinaryMathematicalMorphology/include/itkErodeObjectMorphologyImageFilter.hxx

@@ -23,7 +23,6 @@ namespace itk
 {
 template <typename TInputImage, typename TOutputImage, typename TKernel>
 ErodeObjectMorphologyImageFilter<TInputImage, TOutputImage, TKernel>::ErodeObjectMorphologyImageFilter()
-  : m_BackgroundValue(PixelType{})
 {
   m_ErodeBoundaryCondition.SetConstant(NumericTraits<PixelType>::max());
   this->OverrideBoundaryCondition(&m_ErodeBoundaryCondition);

Modules/Filtering/BinaryMathematicalMorphology/include/itkObjectMorphologyImageFilter.h

@@ -215,7 +215,7 @@ class ITK_TEMPLATE_EXPORT ObjectMorphologyImageFilter : public ImageToImageFilte
   KernelType m_Kernel{};
 
   /** Pixel value that indicates the object be operated upon */
-  PixelType m_ObjectValue{};
+  PixelType m_ObjectValue{ NumericTraits<PixelType>::OneValue() };
 
   void
   BeforeThreadedGenerateData() override;

Modules/Filtering/BinaryMathematicalMorphology/include/itkObjectMorphologyImageFilter.hxx

@@ -31,8 +31,6 @@ namespace itk
 {
 template <typename TInputImage, typename TOutputImage, typename TKernel>
 ObjectMorphologyImageFilter<TInputImage, TOutputImage, TKernel>::ObjectMorphologyImageFilter()
-  : m_Kernel()
-  , m_ObjectValue(NumericTraits<PixelType>::OneValue())
 {
   m_DefaultBoundaryCondition.SetConstant(PixelType{});
   m_BoundaryCondition = &m_DefaultBoundaryCondition;