Fix support for some restricted path characters

CHANGELOG.md

@@ -5,8 +5,13 @@
 ### Changed
 
 - Requires PHP `8.5`
+- Requires `innmind/url:~5.4`
 - Requires `innmind/black-box:~7.0`
 
+### Fixed
+
+- All paths are declared as file paths to allow otherwise restricted `?` and `#`
+
 ## 4.1.1 - 2026-04-09
 
 ### Fixed

README.md

@@ -21,7 +21,7 @@ use Innmind\Immutable\Str;
 
 $chunks = IO::fromAmbienAuthority()
     ->files()
-    ->read(Path::of('/some/file.ext'))
+    ->read(Path::file('/some/file.ext'))
     ->toEncoding(Str\Encoding::ascii)
     ->chunks(8192); // max length of each chunk
 ```

composer.json

@@ -21,7 +21,7 @@
         "php": "~8.5",
         "innmind/immutable": "~6.0",
         "innmind/mutable": "~1.0",
-        "innmind/url": "~5.0",
+        "innmind/url": "~5.4",
         "innmind/time": "~1.0",
         "innmind/ip": "~4.0",
         "innmind/validation": "~3.0"

documentation/files/read.md

@@ -9,7 +9,7 @@ use Innmind\Url\Path;
 
 $chunks = IO::fromAmbientAuthority()
     ->files()
-    ->read(Path::of('/path/to/file.ext'))
+    ->read(Path::file('/path/to/file.ext'))
     ->chunks(8192);
 ```
 
@@ -23,7 +23,7 @@ use Innmind\Url\Path;
 
 $chunks = IO::fromAmbientAuthority()
     ->files()
-    ->read(Path::of('/path/to/file.ext'))
+    ->read(Path::file('/path/to/file.ext'))
     ->lines();
 ```
 
@@ -40,7 +40,7 @@ use Innmind\Immutable\Str;
 
 $chunks = IO::fromAmbientAuthority()
     ->files()
-    ->read(Path::of('/path/to/file.ext'))
+    ->read(Path::file('/path/to/file.ext'))
     ->toEncoding(Str\Encoding::ascii)
     ->lines();
 ```

documentation/files/write.md

@@ -11,7 +11,7 @@ use Innmind\Immutable\{
 
 $successful = IO::fromAmbientAuthority()
     ->files()
-    ->write(Path::of('/path/to/file.ext'))
+    ->write(Path::file('/path/to/file.ext'))
     ->sink(Sequence::of(
         Str::of('chunk 1'),
         Str::of("new line \n"),

documentation/sockets.md

@@ -43,7 +43,7 @@ $server = IO::fromAmbientAuthority()
     ->sockets()
     ->servers()
     ->unix(Address::of(
-        Path::of('/path/to/socket'),
+        Path::file('/path/to/socket'),
     ))
     ->unwrap();
 ```
@@ -63,7 +63,7 @@ $server = IO::fromAmbientAuthority()
     ->sockets()
     ->servers()
     ->takeOver(Address::of(
-        Path::of('/path/to/socket'),
+        Path::file('/path/to/socket'),
     ))
     ->unwrap();
 ```
@@ -144,7 +144,7 @@ $client = IO::fromAmbientAuthority()
     ->sockets()
     ->clients()
     ->unix(Address::of(
-        Path::of('/path/to/socket'),
+        Path::file('/path/to/socket'),
     ))
     ->unwrap();
 ```

documentation/use-cases/files/chunks.md

@@ -12,7 +12,7 @@ use Innmind\Immutable\Str;
 
 $chunks = IO::fromAmbienAuthority()
     ->files()
-    ->read(Path::of('/some/file.ext'))
+    ->read(Path::file('/some/file.ext'))
     ->toEncoding(Str\Encoding::ascii)
     ->chunks(8192); // max length of each chunk
 ```

documentation/use-cases/files/lines.md

@@ -12,7 +12,7 @@ use Innmind\Immutable\Str;
 
 $lines = IO::fromAmbienAuthority()
     ->files()
-    ->read(Path::of('/some/file.ext'))
+    ->read(Path::file('/some/file.ext'))
     ->toEncoding(Str\Encoding::ascii)
     ->lines();
 ```

proofs/files.php

@@ -6,6 +6,7 @@
     Files\Read,
     Files\Temporary,
     Files\Temporary\Pull,
+    Files\Directory,
 };
 use Innmind\Url\Path;
 use Innmind\Immutable\{
@@ -447,4 +448,22 @@ static function($assert) {
             );
         },
     );
+
+    yield $prove->test(
+        'IO::files() can read a directory containing a #',
+        static function($assert) {
+            $tmp = \sys_get_temp_dir();
+            @\rmdir($tmp.'/innmind/#/');
+            @\mkdir($tmp.'/innmind/#/', recursive: true);
+
+            $assert
+                ->object(
+                    IO::fromAmbientAuthority()
+                        ->files()
+                        ->access(Path::file($tmp.'/innmind/#'))
+                        ->unwrap(),
+                )
+                ->instance(Directory::class);
+        },
+    );
 };

src/Files/Directory.php

@@ -28,7 +28,7 @@ public static function of(
         Path $path,
     ): self {
         if (!$path->directory()) {
-            $path = Path::of($path->toString().'/');
+            $path = Path::file($path->toString().'/');
         }
 
         return new self($capabilities, $path);

src/Internal/Capabilities/Files/AmbientAuthority.php

@@ -234,7 +234,7 @@ private function touch(Path $path): Attempt
     private function rmdir(string $path): Attempt
     {
         return $this
-            ->list(Path::of($path))
+            ->list(Path::file($path))
             ->map(static fn($name) => \sprintf(
                 '%s%s%s',
                 $path,
@@ -244,7 +244,7 @@ private function rmdir(string $path): Attempt
                     default => '',
                 },
             ))
-            ->map(Path::of(...))
+            ->map(Path::file(...))
             ->sink(SideEffect::identity)
             ->attempt(fn($_, $file) => $this->remove($file))
             ->map(static fn() => @\rmdir($path))

src/Sockets/Unix/Address.php

@@ -28,7 +28,7 @@ public static function of(Path $path): self
     #[\NoDiscard]
     public function asPath(): Path
     {
-        return Path::of($this->toString());
+        return Path::file($this->toString());
     }
 
     #[\NoDiscard]