ci: replace dead upstream CI with fork pack-and-verify workflow#3
Merged
Merged
Conversation
Upstream main.yml pins dotnet 6.0.x and has zero runs on this fork; PR InitialForce#1 merged with no checks. Replace it with a workflow scoped to what this fork actually needs: build+pack FFmpeg.AutoGen.Redist and FFmpeg.AutoGen.Bindings.DllImport on windows-latest (dotnet 9.x), run scripts/verify_redist.py's self-tests plus the real gates against the freshly packed Redist nupkg, and upload both nupkgs as artifacts. Job is named `pack-and-verify` per br-ffmpeg-pipeline-61d.8, which pins that context string for branch protection. Drops the upstream codegen step (targets a project removed by the PR InitialForce#1 restructure; bindings drift detection is tracked separately as br-ffmpeg-pipeline-61d.10) and builds only the projects this pipeline needs rather than the whole solution, since FFmpeg.AutoGen.Example has a pre-existing, unrelated compile break (tracked as bd-mdp). Adds workflow_dispatch and a monthly keepalive cron against the 60-day scheduled-workflow auto-disable on inactive public repos, with the bootstrap limitation documented inline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/main.yml(dotnet 6.0.x, ubuntu+windows matrix) has zero runs ever on this fork -- PR DESKTOP-12084: FFmpeg redist ships stale 256 MB static ffmpeg/ffprobe binaries #1 merged with no checks.windows-latest: build FFmpeg.AutoGen.Redist + FFmpeg.AutoGen.Bindings.DllImport (dotnet 9.x), run theFFmpeg.AutoGen.ClangMacroParser.Testsuite, pack both projects, runscripts/verify_redist.py's self-tests plus the real gates against the freshly packed Redist nupkg, and upload both nupkgs as artifacts.pack-and-verifyexactly, per br-ffmpeg-pipeline-61d.8 which pins that context string for branch protection.workflow_dispatchand a monthly keepalive cron (with the 60-day scheduled-workflow auto-disable bootstrap limitation documented inline).Deviations from a literal "build the whole solution" reading
FFmpeg.AutoGenas a buildable project, which no longer exists after PR DESKTOP-12084: FFmpeg redist ships stale 256 MB static ffmpeg/ffprobe binaries #1 split bindings into per-targetFFmpeg.AutoGen.Bindings.*projects (each self-contained, with its owngenerated/). Bindings-drift detection is separate, tracked work: br-ffmpeg-pipeline-61d.10.FFmpeg.AutoGen.Examplehas a pre-existing, unrelated compile break (stillusing FFmpeg.AutoGen.Abstractions, removed from the binding projects by 0e9b0b7 "Make bindings projects self-contained, no dep on abstractions"). Confirmed failing identically on a clean checkout with no workflow changes. Filed separately as bd-mdp rather than fixed here.Test plan
dotnet build+dotnet packfor Redist and Bindings.DllImport succeed and produce nupkgs.scripts/test_verify_redist.py(18/18 pass) andscripts/verify_redist.pyagainst the real freshly-packedFFmpeg.AutoGen.Redist.7.1.2.nupkg-- all 6 gates (manifest/forbidden/sizes/pe-imports/gpl-scan/nuspec) PASS.pull_requesttrigger exercises the new workflow onwindows-latest-- that run is the CI evidence.