Arabic: complete missing translations, fix NewPipe→PipePipe references, and address review feedback - #82
Open
AhmedRX20 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This supersedes my earlier PR completing the Arabic (ar) translation, which was incomplete after being inherited from NewPipe. Closed that one to rebuild cleanly on the current v5.2.4 base file with all review feedback addressed from the start.
Original scope
_newsuffix) entries that still referenced "NewPipe" instead of "PipePipe"Review feedback addressed (Thank you so much @my-live-is-a-lie) for the detailed review, and for the fix commit I built on top of
av_num(technical identifier, not meant to be translated)replies,subscribers,views,videos,watching,listening,days,deleted_downloads_toastplurals — correcting noun vs. verb-form confusion and dropping redundant %s where the Arabic quantity form makes the count implicit (zero/one/two)clear,clear_download_history,detail_drag_description,detail_uploader_thumbnail_view_description,error_path_creation,failed_streams,caption_setting_descriptionFull re-sync against base strings.xml v5.2.4
copyright,title_staff_listlimit_data_usage_description_liststring-array (9 items)downloads/downloads_titleto match the term used everywhere elseVerified
av_num(intentionally untranslated)Ready for review.