Allow PlayerSelectors via Brigadier using CB reflection#163
Closed
R00tB33rMan wants to merge 4 commits into
Closed
Allow PlayerSelectors via Brigadier using CB reflection#163R00tB33rMan wants to merge 4 commits into
R00tB33rMan wants to merge 4 commits into
Conversation
Contributor
Author
|
Hey @jpenilla, this is a relatively critical fix that effectively fixes a good portion of what makes Incendo useful. Is there anything wrong with the approach I applied? |
WouterGritter
approved these changes
Jul 19, 2026
jpenilla
added a commit
that referenced
this pull request
Jul 20, 2026
Minecraft 1.21.1 added an allowSelectors parameter to EntityArgument's internal parse overload. CraftBukkit consequently moved its existing overridePermissions parameter to a three-argument overload. Prefer that overload when available, while retaining the legacy CraftBukkit overload for older Minecraft versions. Refs #156 Supersedes #163 Co-authored-by: RootBeer <36140389+R00tB33rMan@users.noreply.github.com>
jpenilla
added a commit
that referenced
this pull request
Jul 20, 2026
Minecraft 1.21.1 added an allowSelectors parameter to EntityArgument's internal parse overload. CraftBukkit consequently moved its existing overridePermissions parameter to a three-argument overload. Prefer that overload when available, while retaining the legacy CraftBukkit overload for older Minecraft versions. Refs #156 Supersedes #163 Co-authored-by: RootBeer <36140389+R00tB33rMan@users.noreply.github.com>
Member
|
Thanks for identifying the CraftBukkit signature change and proposing the compatibility fix. We landed an equivalent implementation in Your contribution is credited with a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CraftBukkit (or Paper's) EntityArgument seemingly exposes ArgumentType.