Repository navigation
[plant, do not merge] hq#58 S2: shellcheck - #22
Closed
InauguralPhysicist wants to merge 2 commits into
Closed
InauguralPhysicist wants to merge 2 commits into
InauguralPhysicist wants to merge 2 commits into
Conversation
`brew test-bot --only-tap-syntax` runs `brew style <tap>`, `brew readall --os=all --arch=all <tap>` and the full-tap `brew audit`. The first two do not depend on the host, and all three ran on every matrix leg. On macos-15-intel `brew style` alone took 5m09s of an 11m54s leg (run 40850464673), against 20 s on ubuntu-latest; over the four-week window the step was 314 s p50 of the 717 s critical-path PR leg (hq#58, SM-HB-3). A leg now skips the step only when it is named, with a reason, in the reviewed .github/tap-syntax-skip-allowlist.txt (today: macos-15-intel and macos-latest). scripts/tap_syntax_legs.py makes the per-leg decision and fails the run instead of deciding when every leg would skip, an entry has no reason or is duplicated, an entry names a leg not in the matrix, the matrix uses include/exclude, or the leg is not in the matrix. A leg not listed runs tap-syntax, and the step condition is `!= 'false'`, so a missing decision also runs it. scripts/test_tap_syntax_legs.py (16 cases) runs in the same step on every leg. Each macOS leg keeps its host-OS checks on formula PRs: the --only-formulae step runs `brew style --formula` and `brew audit --formula --online --git` per leg. What the macOS legs no longer run is the full-tap audit on push and on PRs that do not touch the formula. --only-cleanup-before is kept on every leg. On hosted runners it moves /Library/Frameworks/Python.framework aside and purges unbrewed files from the prefix before the bottle build (89 s on intel); dropping it would make the build environment less hermetic, not just faster. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0149GnPvac4QFD5y1CrHCcb1
Planted fault for #21; this branch is closed and deleted after its brew test-bot run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0149GnPvac4QFD5y1CrHCcb1
Member
Author
|
Plant result (run https://github.com/InauguralSystems/homebrew-eigenscript/actions/runs/41351893152): ubuntu-latest RED at Generated by Claude Code |
Member
Author
|
Correction: the PR is closed, but the branch Generated by Claude Code |
14 of 15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Planted fault for #21. Do not merge; this PR will be closed and its branch deleted once its
brew test-botrun completes.Branch
claude/ci58-hb-s2-plant-shellcheckis #21's head (628a30f) plus one commit that addsscripts/ci_plant.shcontainingecho $1(shellcheck SC2086).brew style <tap>runs shellcheck with--enable=all, so the ubuntu-latest leg should go RED atRun brew test-bot --only-tap-syntax. Both macOS legs skip tap-syntax by allowlist and the formula is unchanged, so they should stay GREEN.The result (which legs went red, at which step and line) is recorded in #21's
Plant: red before, green aftersection.Generated by Claude Code