Repository navigation
Create successor pre-registration for item 3 (#59) - #63
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Under the successor rule all 35 frozen-rule settled reverse runs decay to the origin, so that direction has denominator 0 and gives no positive evidence. The controls cover three of four directions; the record now says so instead of leaving it implicit in the oracle list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KC99CmwatKssQYggkBCgwF
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 891f451268
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| digest = hashlib.sha256(new.read_bytes()).hexdigest() | ||
| print(f"PASS: successor table sha256={digest}") |
There was a problem hiding this comment.
If oracle_settled.csv is regenerated with different denominators or accidentally modified, this acceptance check still prints PASS and exits successfully: it computes the digest but never compares it with oracle_settled.family_b_table_sha256 in manifest.json. Since this table freezes the successor experiment's coverage denominators, accepting a changed table silently changes the retention gate. Load the registered digest and assert equality before reporting success.
Useful? React with 👍 / 👎.
Closes #59
Built by a Codex Cloud task: https://chatgpt.com/codex/tasks/task_e_6ae2567843c8832da67a4f01afdb1d1f. Its red/green and gate evidence is in the task log.