Repository navigation
builtins: set_at reads its buffer argument by reference, not through a stack view (#1859) - #1865
Merged
Merged
Conversation
…a stack view (#1859) gcc 14 warned -Wreturn-local-addr in builtin_set_at when it compiled the amalgamation (CI's extensions/server job; main too). The argument came through BUILTIN_LIST_VIEW, whose compound-literal view lives on the stack. The buffer branch only uses the value when it is a VAL_BUFFER, which is a reference element, never the view, so it was a false positive. gcc could not see that across the inlined slot_view. list_get_ref returns the element itself, or NULL for a numeric slot, so the branch is equivalent and the construct is gone. The strict-shape contract's pinned source hash for builtin_set_at is updated with it. Implemented by Codex Cloud task task_e_6ad6e5220010832d8bba847bbbf0f4ee. The review kept only this change. The task also fixed the -O0/-O1 warnings, which are #1775 and the subject of contributor PR #1799, so they were left out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KC99CmwatKssQYggkBCgwF
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1859
gcc 14 warned
-Wreturn-local-addrinbuiltin_set_atwhen compiling the amalgamation (CI'sextensions / serverjob; main too).BUILTIN_LIST_VIEW, whose compound-literal view lives on the stack.VAL_BUFFER, a reference element, never the view. gcc could not see that across the inlinedslot_view.list_get_refreturns the element itself, or NULL for a numeric slot, so the branch is equivalent and the construct is gone.builtin_set_atis updated with it.Scope: the Codex Cloud task that produced this also fixed the
-O0/-O1warnings. Those are #1775, and contributor PR #1799 already fixes them, so they were left out.Verification: CI's
extensions / serverlog (gcc 14) must show no-Wreturn-local-addr. That is checked before this enters the queue.🤖 Generated with Claude Code
https://claude.ai/code/session_01KC99CmwatKssQYggkBCgwF