Repository navigation
Add CI job to grade EigenLua (#1658) - #69
Conversation
Built by a Codex Cloud task: https://chatgpt.com/codex/tasks/task_e_6ae26c9954dc832d84b85691a9abcf60
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3873131a2f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| *) | ||
| observed_n=$((observed_n + 1)) | ||
| if [[ -z ${ledgered[$key]:-} ]]; then | ||
| printf 'LEDGER unexpected %s verdict=%s\n' "$key" "${row_verdict[$key]}" >&2 | ||
| unexpected_n=$((unexpected_n + 1)) |
There was a problem hiding this comment.
When a previously ledgered divergence regresses to a crash or hang, this check still accepts it because it compares only row names, not the recorded failure behavior. For example, D/int_wrap.lua is documented as DIVERGE, but a CRASH on that row does not increment unexpected_n, so the new CI job remains green if other rows are unchanged. Executing the ledger-check block with all 34 ledgered rows set to CRASH likewise returns exit 0. Preserve and validate the expected verdicts (at least rejecting newly introduced crashes, hangs, and unstable results) rather than treating every non-PASS/MATCH outcome as an accepted divergence.
Useful? React with 👍 / 👎.
Refs InauguralSystems/EigenScript#1658
Built by a Codex Cloud task: https://chatgpt.com/codex/tasks/task_e_6ae26c9954dc832d84b85691a9abcf60. Its red/green and gate evidence is in the task log.