Repository navigation
Fix sparse integer keys memory usage (#55) - #67
Conversation
Built by a Codex Cloud task: https://chatgpt.com/codex/tasks/task_e_6ae241561858832d8451fb5c735d8584
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fe10b7cabf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| local radius is 2 * (t[4][5] + 1) | ||
| numeric_admit is k >= t[4][6] - radius and k <= t[4][6] + radius |
There was a problem hiding this comment.
For a table populated with t[1000000001] = 1; t[1000000003] = 2, the second key now passes this admission check because it is within the radius of the first key. However, numeric storage still uses absolute indices: the loop at lines 880–881 appends over a billion null entries for this two-entry table, causing excessive memory consumption or an out-of-memory failure. Previously both keys remained in the identity map. Offset-relative density is only safe if storage is also offset-relative, or if admission retains a bound on absolute padding.
Useful? React with 👍 / 👎.
Closes #55
Built by a Codex Cloud task: https://chatgpt.com/codex/tasks/task_e_6ae241561858832d8451fb5c735d8584. Its red/green and gate evidence is in the task log.