Deploy current main to GitHub Pages automatically - #72
Open
beanbean9339 wants to merge 1 commit into
Open
beanbean9339 wants to merge 1 commit into
beanbean9339 wants to merge 1 commit into
Conversation
4 tasks
Collaborator
Author
egrace479
reviewed
Sep 28, 2026
|
|
||
| concurrency: | ||
| group: pages | ||
| cancel-in-progress: false |
Member
There was a problem hiding this comment.
Suggested change
| cancel-in-progress: false | |
| cancel-in-progress: true |
In case of multiple PRs coming in.
egrace479
requested changes
Sep 28, 2026
egrace479
left a comment
egrace479
left a comment
Member
There was a problem hiding this comment.
There seem to be a few redundancies here with the ci workflow. Small note: the pages related actions have newer versions, so suggested those.
Comment on lines
+37
to
+39
|
|
||
| - name: Run tests | ||
| run: npm run test |
Member
There was a problem hiding this comment.
Suggested change
| - name: Run tests | |
| run: npm run test |
Tests are run with the ci workflow before a PR is merged, no?
| - name: Upload Pages artifact | ||
| uses: actions/upload-pages-artifact@v4 | ||
| with: | ||
| path: dist |
Member
There was a problem hiding this comment.
Suggested change
| path: dist | |
| path: './dist' |
Comment on lines
+44
to
+46
| - name: Validate metadata files | ||
| run: npm run validate:metadata | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| - name: Validate metadata files | |
| run: npm run validate:metadata |
I think this is also part of the ci workflow.
| ### GitHub Pages deployment | ||
|
|
||
| The `Deploy GitHub Pages` workflow runs on every push to `main` (and can be run | ||
| manually). It installs dependencies, runs tests and metadata validation, builds |
Member
There was a problem hiding this comment.
Suggested change
| manually). It installs dependencies, runs tests and metadata validation, builds | |
| manually). It installs dependencies, builds |
Following their removal. Since we have branch protections, there is no push to main without a PR first; tests and metadata validation are run with the PRs, so no need to run again.
| uses: actions/configure-pages@v5 | ||
|
|
||
| - name: Upload Pages artifact | ||
| uses: actions/upload-pages-artifact@v4 |
Member
There was a problem hiding this comment.
Suggested change
| uses: actions/upload-pages-artifact@v4 | |
| uses: actions/upload-pages-artifact@v5 |
|
|
||
| - name: Deploy Pages | ||
| id: deployment | ||
| uses: actions/deploy-pages@v4 No newline at end of file |
Member
There was a problem hiding this comment.
Suggested change
| uses: actions/deploy-pages@v4 | |
| uses: actions/deploy-pages@v5 | |
| run: npm run validate:metadata | ||
|
|
||
| - name: Configure Pages | ||
| uses: actions/configure-pages@v5 |
Member
There was a problem hiding this comment.
Suggested change
| uses: actions/configure-pages@v5 | |
| uses: actions/configure-pages@v6 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
distartifact to GitHub Pages on every push tomain, with a manual trigger available.gh-pagesbranch until the first successful workflow deployment.Tracks #73 for the Pages source switch and live deployment verification. Keep that issue open until the deployed site updates automatically.
One-time setting after merge
In Settings > Pages > Build and deployment > Source, select GitHub Actions. The current legacy branch-based Pages source uses
gh-pages; aGITHUB_TOKENpush to that branch does not reliably trigger a Pages rebuild, so this PR uses the official artifact deployment actions instead.Validation
npm run test(104 passed),npm run validate:metadata(passed),npm run build(passed).