Skip to content

Lower leaf cert validity to 199 days - #10976

Open
farhan900720-web wants to merge 7 commits into
Icinga:masterfrom
farhan900720-web:lower-leaf-cert-validity
Open

Lower leaf cert validity to 199 days#10976
farhan900720-web wants to merge 7 commits into
Icinga:masterfrom
farhan900720-web:lower-leaf-cert-validity

Conversation

@farhan900720-web

@farhan900720-web farhan900720-web commented Aug 5, 2026

Copy link
Copy Markdown

refs #10437

Describe the solution
As discussed in the issue by @Al2Klimov, this PR takes the first step in the phased approach to comply with CA/Browser-Forum guidelines by lowering the leaf certificate validity from 397 days to 199 days.

Changes made:

  • Updated LEAF_VALID_FOR to 199 days in lib/base/tlsutility.hpp.
  • Updated the corresponding expiration comment in test/base-tlsutility.cpp.
  • Added my name to the AUTHORS file as a first-time contributor.

Taking the first step to lower the leaf certificate validity to 199 days to comply with CA/Browser-Forum guidelines. Also updated the corresponding test check and added name to AUTHORS.

fixes #YOUR_ISSUE_NUMBER
@cla-bot

cla-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @farhan900720-web

Details
  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@bobapple

bobapple commented Aug 5, 2026

Copy link
Copy Markdown
Member

@cla-bot check

@cla-bot cla-bot Bot added the cla/signed label Aug 5, 2026

@Al2Klimov Al2Klimov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only two things and we can call it a day:

Comment thread AUTHORS Outdated
Yonas Habteab <yonas.habteab@icinga.com>
Zachary McGibbon <zachary.mcgibbon@gmail.com>
Zoltan Nagy <abesto@abesto.net>
Farhan <farhan900720@gmail.com> No newline at end of file

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the missing end of line.

Comment thread AUTHORS Outdated
Yonas Habteab <yonas.habteab@icinga.com>
Zachary McGibbon <zachary.mcgibbon@gmail.com>
Zoltan Nagy <abesto@abesto.net>
Farhan <farhan900720@gmail.com> No newline at end of file

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the file sorted alphabetically.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doing it in a minute

@Al2Klimov Al2Klimov added area/distributed Distributed monitoring (master, satellites, clients) area/api REST API labels Aug 5, 2026
@farhan900720-web

farhan900720-web commented Aug 5, 2026

Copy link
Copy Markdown
Author

i have made the AUTHOR file sorted in alphabetical order and added a new line at the end of file .
please let me know is there any other mistakes done by me or improvement needed as it would be very helpful for me as a newbie .

Comment thread AUTHORS Outdated
@farhan900720-web

Copy link
Copy Markdown
Author

@Al2Klimov I have applied the fixes for the alphabetical sorting and the trailing newline. It is ready for the workflows to be approved.

@Al2Klimov
Al2Klimov removed their request for review August 6, 2026 08:02
@Al2Klimov
Al2Klimov removed their request for review August 6, 2026 15:13
@farhan900720-web
farhan900720-web force-pushed the lower-leaf-cert-validity branch from 8e3b80b to 142c3c1 Compare August 6, 2026 15:56
@farhan900720-web

farhan900720-web commented Aug 6, 2026

Copy link
Copy Markdown
Author

@Al2Klimov

  1. I have amended my commit to update the Git author metadata so it perfectly matches my entry in the AUTHORS file. The mismatch that caused the check to fail earlier should now be fully resolved. Since I am a new contributor, please approve and re-trigger the workflow checks for me when you get a chance .

  2. Also if this is too would not work can you tell me what should i do then .

thanks.

@Al2Klimov Al2Klimov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While on it, split your changes into two commits:

  1. AUTHORS update
  2. Everything else

Comment thread AUTHORS
Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>
Fabian Röhl <mail@fabian-roehl.de>
Fabian Werner <47595490+fabieins@users.noreply.github.com>
Farhan <farhan900720@gmail.com>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread AUTHORS
Yonas Habteab <yonas.habteab@icinga.com>
Zachary McGibbon <zachary.mcgibbon@gmail.com>
Zoltan Nagy <abesto@abesto.net>
Zoltan Nagy <abesto@abesto.net> No newline at end of file

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get rid of this diff, whatever it takes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/api REST API area/distributed Distributed monitoring (master, satellites, clients) cla/signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants