Lower leaf cert validity to 199 days - #10976
Conversation
Taking the first step to lower the leaf certificate validity to 199 days to comply with CA/Browser-Forum guidelines. Also updated the corresponding test check and added name to AUTHORS. fixes #YOUR_ISSUE_NUMBER
|
Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA). Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA. After that, please reply here with a comment and we'll verify. Contributors that have not signed yet: @farhan900720-web Details
|
|
@cla-bot check |
Al2Klimov
left a comment
There was a problem hiding this comment.
Only two things and we can call it a day:
| Yonas Habteab <yonas.habteab@icinga.com> | ||
| Zachary McGibbon <zachary.mcgibbon@gmail.com> | ||
| Zoltan Nagy <abesto@abesto.net> | ||
| Farhan <farhan900720@gmail.com> No newline at end of file |
| Yonas Habteab <yonas.habteab@icinga.com> | ||
| Zachary McGibbon <zachary.mcgibbon@gmail.com> | ||
| Zoltan Nagy <abesto@abesto.net> | ||
| Farhan <farhan900720@gmail.com> No newline at end of file |
There was a problem hiding this comment.
Keep the file sorted alphabetically.
|
i have made the AUTHOR file sorted in alphabetical order and added a new line at the end of file . |
|
@Al2Klimov I have applied the fixes for the alphabetical sorting and the trailing newline. It is ready for the workflows to be approved. |
8e3b80b to
142c3c1
Compare
thanks. |
Al2Klimov
left a comment
There was a problem hiding this comment.
While on it, split your changes into two commits:
- AUTHORS update
- Everything else
| Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl> | ||
| Fabian Röhl <mail@fabian-roehl.de> | ||
| Fabian Werner <47595490+fabieins@users.noreply.github.com> | ||
| Farhan <farhan900720@gmail.com> |
There was a problem hiding this comment.
Change this line exactly as told by https://github.com/Icinga/icinga2/actions/runs/31117995027/job/92814226117?pr=10976
| Yonas Habteab <yonas.habteab@icinga.com> | ||
| Zachary McGibbon <zachary.mcgibbon@gmail.com> | ||
| Zoltan Nagy <abesto@abesto.net> | ||
| Zoltan Nagy <abesto@abesto.net> No newline at end of file |
There was a problem hiding this comment.
Get rid of this diff, whatever it takes.
refs #10437
Describe the solution
As discussed in the issue by @Al2Klimov, this PR takes the first step in the phased approach to comply with CA/Browser-Forum guidelines by lowering the leaf certificate validity from 397 days to 199 days.
Changes made:
LEAF_VALID_FORto 199 days inlib/base/tlsutility.hpp.test/base-tlsutility.cpp.AUTHORSfile as a first-time contributor.