feat(path): implement Lore-root centric pathing#61
Open
c-ferrier wants to merge 2 commits into
Open
Conversation
…tability Shifts the protocol to a Lore-root centric coordinate system. Anchors GitClient execution at the loreRoot and uses the --relative flag to ensure all stored paths are relative to the project boundary rather than the Git repository root. This resolves critical drift detection failures in subdirectories (lore stale) and provides automatic isolation in monorepo environments. Root discovery now strictly respects .git boundaries, preventing context leakage between unrelated repositories. Lore-id: b112559e Constraint: GitClient MUST execute from loreRoot Constraint: PathResolver MUST normalize user inputs relative to loreRoot Constraint: Discovery commands MUST implicitly scope to '.' when loreRoot != gitRoot Constraint: ConfigLoader MUST stop upward search at .git boundaries Tested: Verified monorepo isolation with manual project-a/project-b scenario Tested: Confirmed 'lore stale' drift detection in nested subdirectories Tested: All 435 unit tests passing including updated PathResolver suite Tested: Verified boundary safety in nested-Git repository scenarios Confidence: high Scope-risk: moderate Reversibility: clean Assisted-by: Gemini:CLI [lore-protocol]
Introduces an isScoped flag to AtomRepository that conditionalizes implicit path scoping. When Lore is initialized in a subproject (loreRoot != gitRoot), queries are automatically scoped to the project directory to provide isolation. When standing at the repository root, Lore operates in global mode, showing all atoms including empty commits. This ensures full visibility at the top level while maintaining clean isolation within individual projects. Lore-id: deec0524 Constraint: Discovery commands MUST only scope to '.' when isScoped is true Constraint: Empty commits MUST be visible at the Git root Tested: Added unit tests for isScoped guard in AtomRepository.test.ts Tested: Verified dual-mode behavior (Global vs Isolated) with manual monorepo scenario Tested: All 41 AtomRepository tests passing Confidence: high Assisted-by: Gemini:CLI [lore-protocol]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a strict Lore-root centric coordinate system for all paths within the protocol.
Key Changes:
Closes #60