Added test cases for new Eurotherm records#673
Merged
Conversation
Closed
4 tasks
With additional PVs added the previous delay caused too big a backlog causing this and other tests to fail
FreddieAkeroyd
force-pushed
the
Ticket8688_Fix_Eurotherm_NewFields
branch
from
1fa5191 to
a289364
Compare
| @parameterized.expand(parameterized_list(TEST_VALUES)) | ||
| @skip_if_recsim("Backdoor not available in recsim") | ||
| def test_WHEN_automan_set_via_backdoor_THEN_automan_updates(self, _, val): | ||
| self.ca.set_pv_value("A01:AUTOMAN", 1) |
Member
There was a problem hiding this comment.
The test should be setting AUTOMAN:SP rather than AUTOMAN. Also you coudl make the parameterised list have [0,1] and then use val in the test
| self.ca.set_pv_value("A01:AUTOMAN", 0) | ||
| self.ca.assert_that_pv_is("A01:AUTOMAN", "OFF") | ||
|
|
||
| @parameterized.expand(parameterized_list(TEST_VALUES)) |
Member
There was a problem hiding this comment.
you probably need different values here in the parameterised list e.g. 0 and 1 and ten you can use val in your tests - similar to as with AUTOMAN above
FreddieAkeroyd
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related with the ticket