Add MODS attributes to spin affected products

[lacoak21]

Change Summary

partially closes #3493

Overview

File changes

Testing

[Copilot]

Copilot review overview

🔵 Needs a closer look

Add Major Version 2 MODS entries for the Lo histogram and monitor-rate products.

Review effort: Lite
Findings: None

What changed in this PR

Updates CDF metadata with MODS histories for products affected by corrected spin tables and SPICE kernels.

Changes:

• Adds MODS entries across seven instrument configurations.
• Records version updates, including IDEX Major Version 3.
• Lo histogram and monitor-rate products still require Major Version 2 history entries.

File	Summary
imap_processing/​cdf/​config/​imap_ultra_global_cdf_attrs.yaml	Adds MODS history for Ultra products.
imap_processing/​cdf/​config/​imap_swe_global_cdf_attrs.yaml	Adds MODS history for SWE products.
imap_processing/​cdf/​config/​imap_mag_global_cdf_attrs.yaml	Adds MODS history for MAG products.
imap_processing/​cdf/​config/​imap_lo_global_cdf_attrs.yaml	Adds MODS history for Lo products.
imap_processing/​cdf/​config/​imap_idex_global_cdf_attrs.yaml	Adds the IDEX Major Version 3 entry.
imap_processing/​cdf/​config/​imap_hi_global_cdf_attrs.yaml	Adds MODS history for Hi products.
imap_processing/​cdf/​config/​imap_glows_global_cdf_attrs.yaml	Adds MODS history for GLOWS products.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[lacoak21]

This is not planned for data release 2 anymore. I will keep this open until we do need it.

[leowerneck]

LGTM.

I had one question, but I'd say it's non-blocking because I'm not sure it's relevant:

In imap_spacecraft_global_cdf_attrs.yaml, does imap_spacecraft_l1a_quaternions depend on the changes to attitude_history? In the orchestration dependencies I found (l1a, pointing-attitude), whose output is:

  outputs:
    - source: spacecraft
      data_type: l1a
      descriptor: pointing-attitude
      major_version: 1

but it's not obvious to me whether they are related or not.

[leowerneck]

One additional question: should all products have a MODS attribute describing Major version 1? For example, these randomly selected ones have nothing:

imap_ultra_l1a_45sensor-imgparams:
    <<: *instrument_base
    Data_type: L1A_45Sensor-ImgParams>Level-1A Image Parameters for Ultra45
    Logical_source: imap_ultra_l1a_45sensor-imgparams
    Logical_source_description: IMAP Mission IMAP-Ultra Instrument Level-1A Image Parameters Data for Ultra45

imap_ultra_l1a_90sensor-imgparams:
    <<: *instrument_base
    Data_type: L1A_90Sensor-ImgParams>Level-1A Image Parameters for Ultra90
    Logical_source: imap_ultra_l1a_90sensor-imgparams
    Logical_source_description: IMAP Mission IMAP-Ultra Instrument Level-1A Image Parameters Data for Ultra90

Should they be changed to

imap_ultra_l1a_45sensor-imgparams:
    <<: *instrument_base
    Data_type: L1A_45Sensor-ImgParams>Level-1A Image Parameters for Ultra45
    Logical_source: imap_ultra_l1a_45sensor-imgparams
    Logical_source_description: IMAP Mission IMAP-Ultra Instrument Level-1A Image Parameters Data for Ultra45
    MODS:
      - >-
        Major version 1, Aug. 1, 2026 - Initial release.

imap_ultra_l1a_90sensor-imgparams:
    <<: *instrument_base
    Data_type: L1A_90Sensor-ImgParams>Level-1A Image Parameters for Ultra90
    Logical_source: imap_ultra_l1a_90sensor-imgparams
    Logical_source_description: IMAP Mission IMAP-Ultra Instrument Level-1A Image Parameters Data for Ultra90
    MODS:
      - >-
        Major version 1, Aug. 1, 2026 - Initial release.

or not? This is out of scope for this PR, I'm just trying to check if there is additional work to be done here. I couldn't find an open issue on this.

[lacoak21]

One additional question: should all products have a MODS attribute describing Major version 1? For example, these randomly selected ones have nothing:

Yes- I keep meaning to make a ticket for that! I think all of them should have the first release MODS.

[leowerneck]

I can open the ticket, if you don't mind.

[lacoak21]

No not at all thanks! Im looking into the quaternions job

[lacoak21]

LGTM.

I had one question, but I'd say it's non-blocking because I'm not sure it's relevant:

In imap_spacecraft_global_cdf_attrs.yaml, does imap_spacecraft_l1a_quaternions depend on the changes to attitude_history? In the orchestration dependencies I found (l1a, pointing-attitude), whose output is:

  outputs:
    - source: spacecraft
      data_type: l1a
      descriptor: pointing-attitude
      major_version: 1

but it's not obvious to me whether they are related or not.

I dont think quaternions are affected. I dont see any kernels other than the time kernels. The pointing attitude is but its not a CDF in the same way.

[tmplummer]

had one question, but I'd say it's non-blocking because I'm not sure it's relevant:

In imap_spacecraft_global_cdf_attrs.yaml, does imap_spacecraft_l1a_quaternions depend on the changes to attitude_history? In the orchestration dependencies I found (l1a, pointing-attitude), whose output is:

  outputs:
    - source: spacecraft
      data_type: l1a
      descriptor: pointing-attitude
      major_version: 1

but it's not obvious to me whether they are related or not.

The spacecraft quaternions don't depend on the changes to attitude history. Perhaps they should be fixed, but that would require us to make code changes to manually shift the times encoded in the packets. This is why it is better to just use SPICE ;)

The pointing-attitude job depends on the attitude_history but it:

1. doesn't have a major version since it is a kernel
2. will match the version of the AH file it was generated from
3. calculates the mean spin-axis during a pointing, so we would not expect it to change at all from the AH file updates

[jtniehof]

I don't think major version 1 needs a MODS...it only needs to be changes. Of course now I see the description says to include a date. I'm not getting that fixed for L3 right this second :)

[lacoak21]

I don't think major version 1 needs a MODS...it only needs to be changes. Of course now I see the description says to include a date. I'm not getting that fixed for L3 right this second :)

Right I think I got hung up on this:

"MODS attribute entry (one entry per major version)."

Maybe ill just skip it for now then too.

[leowerneck]

Does that mean we shouldn't include the Major version 1 lines, but only add MODS entries with Major version 2 onwards? IDEX has a few stray Major version 1s that should be cleaned up, if that's the case.

[lacoak21]

Yeah I had added the major_version 1 mods to IDEX based on another discussion in the PR with those changes. We decided to add the major version 1 MODS but now it might just make more sense to start with v2. Ill make those changes now but if anyone has a strong opinion about keeping them let me know.

[leowerneck]

The pointing-attitude job depends on the attitude_history but it:

1. doesn't have a major version since it is a kernel

@tmplummer Should the dependency YAML files contain any indication of this? I couldn't identify this by looking at them, unless the indication is descriptor: pointing-attitude?

[tmplummer]

LGTM