Skip to content

BUG - Fix Docker-related failures in GLOWS integration tests - #229

Merged
leowerneck merged 3 commits into
IMAP-Science-Operations-Center:mainfrom
leowerneck:223-bug---glows-integration-tests-fail-to-run
Oct 8, 2026
Merged

leowerneck merged 3 commits into
IMAP-Science-Operations-Center:mainfrom
leowerneck:223-bug---glows-integration-tests-fail-to-run

Conversation

@leowerneck

@leowerneck leowerneck commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Closes #223.

Overview

This PR fixes failures to the GLOWS integration tests introduced in #213.

File changes

  • ‎Dockerfile_glows_integration.dockerignore: added (main fix).
  • tests/integration/test_glows_processor_integration.py: reformatted, catch docker build errors.

Potential Additional Work

These would be nice additions/changes:

  • Reduce integration tests' scope so that it doesn't take as long to process (current CI runtime is 107 minutes!).
  • Sync expected major version from the test and what's in Prod.

@leowerneck leowerneck added bug Something isn't working Ins: GLOWS Related to the GLOWS instrument labels Oct 7, 2026
@leowerneck leowerneck self-assigned this Oct 7, 2026
@leowerneck leowerneck changed the title 223 bug glows integration tests fail to run BUG - Fix Docker-related failures in GLOWS integration tests Oct 8, 2026
@leowerneck
leowerneck requested a balanced review from Copilot October 8, 2026 13:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes directly address the missing Docker build context and improve failure diagnostics without introducing unresolved issues.

0 open findings

What changed in this PR

Fixes GLOWS integration Docker builds broken by the root Docker ignore rules.

Changes:

  • Adds a GLOWS-specific Docker build-context allowlist.
  • Improves Docker build error reporting and creates required mount directories.
  • Reformats the integration test.
File Description
Dockerfile_glows_integration.dockerignore Includes resources required by the integration image.
tests/​integration/​test_glows_processor_integration.py Handles build failures and fresh-checkout directories.

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

@leowerneck
leowerneck requested a review from jtniehof October 8, 2026 14:02
@leowerneck leowerneck added this to IMAP Oct 8, 2026
@leowerneck
leowerneck merged commit 73e20e8 into IMAP-Science-Operations-Center:main Oct 8, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Ins: GLOWS Related to the GLOWS instrument

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

BUG - GLOWS integration tests fail to run

2 participants