Repository navigation
SWAPI: Add velocity, covariance, and uncertainty in GSE coordinates - #221
leowerneck wants to merge 21 commits into
Conversation
leowerneck
added
enhancement
|
@hafarooki Your review would also be appreciated. |
leowerneck
changed the title
*_gse_earth and *_gse_sun quantities
| NAME: proton_sw_velocity_gse_earth | ||
| DATA_TYPE: CDF_REAL4 | ||
| FIELDNAM: Proton Solar Wind Velocity (GSE, Earth Frame) | ||
| CATDESC: Solar wind proton bulk velocity vector in GSE coordinates (Earth frame) |
There was a problem hiding this comment.
Is CATDESC supposed to have a period at the end?
There was a problem hiding this comment.
I don't see any other example in that file that ends with a period:
grep -E '^[[:space:]]*CATDESC:.*\.$' imap_l3_processing/cdf/config/imap_swapi_l3a_variable_attrs.yamlreturns nothing.
| eclipj2000_from_rtn = get_rotation_matrix( | ||
| et, SpiceFrame.IMAP_RTN, SpiceFrame.ECLIPJ2000 | ||
| ) | ||
| gse_from_eclipj2000 = spiceypy.sxform( |
There was a problem hiding this comment.
More comments are needed to explain the shapes and dimensions of these arrays
leowerneck
changed the title
*_gse_earth and *_gse_sun quantities
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…oved unnecessary docstring
c6f960d to
b2d293c
Compare
|
My big question before looking at details: have we confirmed exactly what WIND is reporting as GSE? Is it GSE relative to Sun, GSE less a fixed 30km/s in Y, or a "proper" aGSE rotated into SW (nominal or actual)? Since matching WIND (and other L1) is a key driver, we should be as precise as we can. Has someone looped in with Savvas? (Slow on the uptake here because I've been focusing on the release 2 issues). |
|
After discussions with @mmshaw and @mecuesta, combined with the result of the long email thread, my understanding is that IMAP will report GSE in the Earth's frame, and that it should be called "_gse" (not "_gse_earth"). We won't try to match other missions if they use something else. My goal for this PR was to introduce GSE (not aGSE) coordinates in the Earth's frame. The steps I took were:
Hameed can correct me if I'm wrong, but I believe he found that WIND/OMNI use GSE coordinates in the Sun's frame. I haven't looped in with Savvas. |
3 participants
Change Summary
Related to #21.
Overview
This PR is a simplified version of #165 intended to add the transformation to GSE coordinates in the Earth frame. It does not introduce GSM or HAE-J2000, which will be left for a future PR (if still desired).
Testing
All newly added tests pass locally.
Note
The vast majority of the diff in this commit is due to reformatting with
ruff format, which mostly affect the test files.