Repository navigation
BUG - Enable querying by filename - #362
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Legacy science filenames can return no results, and explicit default-valued query options bypass conflict validation.
2 open findings
What changed in this PR
Adds positional filename querying while retaining option-based queries.
Changes:
- Derives query parameters from science, ancillary, and SPICE filenames.
- Rejects filenames combined with query options.
- Adds tests and updates the API demo.
| File | Description |
|---|---|
imap_data_access/cli.py |
Implements filename-based query parsing and filtering. |
tests/test_cli.py |
Tests supported filename types and conflicting options. |
examples/api_demo.ipynb |
Updates the filename-query example. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
leowerneck
requested review from
bryan-harter,
jaredclaypoole,
lacoak21,
tech3371 and
tmplummer
October 12, 2026 20:17
leowerneck
merged commit Oct 13, 2026
4161d0f
into
IMAP-Science-Operations-Center:main
16 checks passed
leowerneck
deleted the
355-bug----query---filename-filename--does-not-work
branch
October 13, 2026 16:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Change Summary
Closes #355.
Overview
This PR introduces the following syntax:
in addition to the standard (and still supported)
Note that passing any querying options after (or before)
FILENAMEwill result in an error, since all query parameters are extracted fromFILENAME.File changes
imap_data_access/cli.py: changed how the CLI parses command line arguments.tests/test_cli.py: added tests for the new CLI syntax.examples/api_demo.ipynb: added new syntax exampleTesting
Running:
uv sync --extra test uv run pytest testsresults in 148 tests passing.