Repository navigation
Conversation
Added a filter for ‘title’
Added additional replaces to solve false positives due to .sec-extension.
Contributor
Author
|
Mitigated a third false positive case: If an unauthorized file extension is used, exc_returned appends ‘.sec’; the IRSS does not do this anymore. The remove has to be done on both sides, because IRSS has appended .sec in earlier versions. And, unfortunately, I’d forgotten to mention the relevant Mantis issue:https://mantis.ilias.de/view.php?id=48178 |
dsstrassner
changed the title
Added replacement of &ILIAS-eLearning#39;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We also have a few cases left over. We have now noticed that their number has continued to rise following the migration due to new submissions. I suspect that these are false positives, which still remain different after each run. I have already identified a few points:
• For example, file names may appear in the IRSS that themselves contain a “/”. However, for comparison purposes, everything after the last ‘/’ is truncated in
exc_returned.filename, as that is where the full path is stored. > The truncation must therefore also take place on the other side.• The IRSS converts certain characters into ASCII codes (e.g. ‘&’). This conversion does not take place for
exc_returned.filename.